Remove dependency on commons-lang3 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was only used to check for strings being null or empty. We don't need a whole extra library dependency for that (especially since OpenSearch already provides a utility method for that). Signed-off-by: Michael Froh <froh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
=========================================
Coverage 83.30% 83.30%
Complexity 337 337
=========================================
Files 43 43
Lines 1270 1270
Branches 155 155
=========================================
Hits 1058 1058
Misses 134 134
Partials 78 78
|
msfroh
requested review from
macohen,
noCharger,
mingshl and
sejli
as code owners
mingshl
approved these changes
Sep 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
Was only used to check for strings being null or empty. We don't need a whole extra library dependency for that (especially since OpenSearch already provides a utility method for that). Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 7e56847)
msfroh
added a commit
that referenced
this pull request
Sep 5, 2023
Was only used to check for strings being null or empty. We don't need a whole extra library dependency for that (especially since OpenSearch already provides a utility method for that). Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 7e56847) Co-authored-by: Michael Froh <froh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was only used to check for strings being null or empty. We don't need a whole extra library dependency for that (especially since OpenSearch already provides a utility method for that).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.