Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline repo groups #664

Merged
merged 2 commits into from
Apr 26, 2023
Merged

baseline repo groups #664

merged 2 commits into from
Apr 26, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Feb 28, 2023

Description

[Describe what this change achieves]

Issues Resolved

Fix #643

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho requested a review from a team as a code owner February 28, 2023 16:12
MAINTAINERS.md Outdated
@@ -6,7 +6,12 @@ This document contains a list of maintainers in this repo. See [opensearch-proje

| Maintainer | GitHub ID | Affiliation |
| ---------------------- | ------------------------------------------------- | ----------- |
| Anantha Krishna Bhatta | [akbhatta](https://github.com/akbhatta) | Amazon |
| David Cui | [davidcui-amzn](https://github.com/davidcui-amzn) | Amazon |
| Joshua Li | [joshuali925](https://github.com/joshuali925) | Amazon |
| Zhongnan Su | [zhongnansu](https://github.com/zhongnansu) | Amazon |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need a vote to get @rupal-bq onto this list

rupal-bq
rupal-bq previously approved these changes Mar 9, 2023
Signed-off-by: Derek Ho <dxho@amazon.com>
@bbarani
Copy link
Member

bbarani commented Apr 25, 2023

Ready to merge. CODEOWNER is green.

@derek-ho derek-ho merged commit a8edd8a into opensearch-project:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
6 participants