Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Upgrade puppeteer #491

Merged
merged 2 commits into from
Oct 5, 2022
Merged

[2.1] Upgrade puppeteer #491

merged 2 commits into from
Oct 5, 2022

Conversation

rupal-bq
Copy link
Member

@rupal-bq rupal-bq commented Oct 4, 2022

Description

  • Upgraded puppeteer to 13.7.0
  • Changed timeout to 300000

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@rupal-bq rupal-bq requested a review from a team as a code owner October 4, 2022 21:58
@codecov-commenter
Copy link

Codecov Report

Merging #491 (4d62193) into 2.1 (0194e01) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.1     #491   +/-   ##
=========================================
  Coverage     74.12%   74.12%           
  Complexity      383      383           
=========================================
  Files            94       94           
  Lines          4008     4008           
  Branches        649      649           
=========================================
  Hits           2971     2971           
  Misses          903      903           
  Partials        134      134           
Flag Coverage Δ
dashboards-reports 76.52% <100.00%> (ø)
reports-scheduler 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/routes/utils/visual_report/visualReportHelper.ts 79.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuali925 joshuali925 merged commit 0d6f21a into opensearch-project:2.1 Oct 5, 2022
@rupal-bq rupal-bq deleted the 2.1-upgrade branch October 6, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants