Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Restrict chromium requests #430

Merged
merged 8 commits into from
Aug 18, 2022

Conversation

joshuali925
Copy link
Member

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 requested a review from a team as a code owner August 17, 2022 17:26
joshuali925 and others added 2 commits August 17, 2022 17:31
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #430 (041f3af) into 2.1 (1d2d929) will decrease coverage by 0.14%.
The diff coverage is 55.55%.

@@             Coverage Diff              @@
##                2.1     #430      +/-   ##
============================================
- Coverage     74.27%   74.12%   -0.15%     
  Complexity      383      383              
============================================
  Files            94       94              
  Lines          3984     4008      +24     
  Branches        641      649       +8     
============================================
+ Hits           2959     2971      +12     
- Misses          891      903      +12     
  Partials        134      134              
Flag Coverage Δ
dashboards-reports 76.52% <55.55%> (-0.34%) ⬇️
reports-scheduler 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/routes/utils/visual_report/visualReportHelper.ts 79.81% <52.00%> (-8.56%) ⬇️
...ashboards-reports/server/routes/utils/constants.ts 100.00% <100.00%> (ø)
...ashboards-reports/server/utils/validationHelper.ts 92.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavithacm kavithacm merged commit 0194e01 into opensearch-project:2.1 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants