Add support for build version qualifiers.

[dblock]

Coming from opensearch-project/opensearch-build#1632, add support for -Dbuild.version_qualifier=.

The distribution build process now supports passing additional optional qualifiers other than the 3 digit versions, e.g. 2.0.0-alpha1. Add the ability to pass additional qualifier to build scripts, and generate artifacts with a version that includes the qualifier.

[peterzhuamazon]

dashboards part: opensearch-project/opensearch-build#1836

[kavilla]

Hi @joshuali925, I see you handled the OpenSearch plugin, are you working on the OpenSearch Dashboards side as well.

Unfortunately for OpenSearch Dashboards we don't have a nice build param as OpenSearch side has yet. You will be able to build and connect successfully to OpenSearch Dashboards yarn plugin_helpers build --opensearch-dashboards-version=2.0.0-alpha1) with an OSD plugin 2.0.0.0 but this will fail within the distribution build.

As for 2.0.0-alpha1 we ask plugins to bump their version [here] to be 2.0.0.0-alpha1 to be supported within the build distribution.

Let me know if you have any follow up questions.

Thanks!

[joshuali925]

Hi @joshuali925, I see you handled the OpenSearch plugin, are you working on the OpenSearch Dashboards side as well.

Unfortunately for OpenSearch Dashboards we don't have a nice build param as OpenSearch side has yet. You will be able to build and connect successfully to OpenSearch Dashboards yarn plugin_helpers build --opensearch-dashboards-version=2.0.0-alpha1) with an OSD plugin 2.0.0.0 but this will fail within the distribution build.

As for 2.0.0-alpha1 we ask plugins to bump their version [here] to be 2.0.0.0-alpha1 to be supported within the build distribution.

Let me know if you have any follow up questions.

Thanks!

Thanks, make sense. I'll update PRs to change dashboards plugins to use -alpha1 as well

[joshuali925]

@kavilla should opensearchDashboardsVersion be 2.0.0-alpha1? i checked core repo didn't find alpha1 qualifier in its version

{
  "id": "reportsDashboards",
  "version": "2.0.0.0-alpha1",
  "opensearchDashboardsVersion": "2.0.0-alpha1",

[kavilla]

Up to you but I might share different opinions than others.

My opinion, is that leave opensearchDashboardsVersion untouched. You can then utilize OpenSearch Dashboards main. Within the build repo we build OpenSearch Dashboards and plugins with a qualifier. This will set OpenSearch Dashboards to be 2.0.0-alpha and within plugins "opensearchDashboardsVersion": "2.0.0-alpha1". So it will be compatible and succeed in the building of distributions.

[joshuali925]

I see, so in plugin builds opensearchDashboardsVersion can be overridden by build args but version cannot. PRs updated.

[kavilla]

Correct! When I have allocation I will try to get that functionality in here: opensearch-project/OpenSearch-Dashboards#1398, note that 2.0.0.0-alpha1 will still work with OSD 2.0.0 but within the build repo it will fail a build check (purposefully) since we want to ensure we output version = 2.0.0.0-alpha1 for plugins.

[anirudha]

we will convert from alpha1 to Rc after core is done with the change.