Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] plugin-helper build script support version qualifier for plugin #1398

Open
kavilla opened this issue Mar 29, 2022 · 1 comment
Open
Labels
build Build related additions or modifications enhancement New feature or request

Comments

@kavilla
Copy link
Member

kavilla commented Mar 29, 2022

Is your feature request related to a problem? Please describe.

Origin: https://github.com/opensearch-project/opensearch-build/pull/1836/files

We can define opensearchDashboardsVersion for plugins but that will leave the plugin version untouched.

Describe the solution you'd like

The ability to specify a plugin version so it build's it with that version (specifically related to qualifiers)

Describe alternatives you've considered

Logic to ensure that if opensearchDashboardsVersion is passed then the plugin version is updated with it as well. Not sure about the implications of this though.

Additional context

n/a

@peterzhuamazon
Copy link
Member

As of now BE plugins are having 4 digits on their zips but FE plugins only have 3 digits:


-rw-r--r-- 1 <>  7020139 Apr 13 20:56 alertingDashboards-1.3.0.zip
-rw-r--r-- 1 <> 16680199 Apr 13 20:54 anomalyDetectionDashboards-1.3.0.zip
-rw-r--r-- 1 <>  5646482 Apr 13 20:55 ganttChartDashboards-1.3.0.zip
-rw-r--r-- 1 <>   602751 Apr 13 20:56 indexManagementDashboards-1.3.0.zip
-rw-r--r-- 1 <> 36259129 Apr 13 20:51 observabilityDashboards-1.3.0.zip
-rw-r--r-- 1 <>  2631839 Apr 13 20:48 queryWorkbenchDashboards-1.3.0.zip
-rw-r--r-- 1 <> 69841373 Apr 13 20:55 reportsDashboards-1.3.0.zip
-rw-r--r-- 1 <>  1105904 Apr 13 20:53 securityDashboards-1.3.0.zip

-rw-r--r-- 1 <> 12287632 Apr 13 20:41 opensearch-alerting-1.3.0.0.zip
-rw-r--r-- 1 <> 12807374 Apr 13 20:51 opensearch-anomaly-detection-1.3.0.0.zip
-rw-r--r-- 1 <>   472082 Apr 13 20:42 opensearch-asynchronous-search-1.3.0.0.zip
-rw-r--r-- 1 <>  5162874 Apr 13 20:52 opensearch-cross-cluster-replication-1.3.0.0.zip
-rw-r--r-- 1 <>  8438383 Apr 13 20:45 opensearch-index-management-1.3.0.0.zip
-rw-r--r-- 1 <>  1183730 Apr 13 20:40 opensearch-job-scheduler-1.3.0.0.zip
-rw-r--r-- 1 <> 10221702 Apr 13 20:48 opensearch-knn-1.3.0.0.zip
-rw-r--r-- 1 <> 16989657 Apr 13 20:40 opensearch-ml-1.3.0.0.zip
-rw-r--r-- 1 <>  6523920 Apr 13 20:54 opensearch-observability-1.3.0.0.zip
-rw-r--r-- 1 <> 61136442 Apr 13 20:51 opensearch-performance-analyzer-1.3.0.0.zip
-rw-r--r-- 1 <>  7013996 Apr 13 20:54 opensearch-reports-scheduler-1.3.0.0.zip
-rw-r--r-- 1 <> 40616638 Apr 13 20:49 opensearch-security-1.3.0.0.zip
-rw-r--r-- 1 <> 19131345 Apr 13 20:53 opensearch-sql-1.3.0.0.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build related additions or modifications enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants