[Backport 2.x] Add field type to query shape and extensive unit tests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add query type to shape and extensive unit tests Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Log query shape if trace log enabled Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Refactor code, handle multifield with test, remove properties cache Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Use only first index and optimization to get properties once per query Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Further refactoring Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> --------- Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> (cherry picked from commit dcf52c2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
deshsidd
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport dcf52c2 from #140.