Otel counters for error metrics #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjcy
requested review from
jainankitk,
deshsidd and
dzane17
as code owners
|
@deshsidd would appreciate it if you can provide some input, since you worked on similar things before on Otel metrics. Thanks. |
ansjcy
force-pushed
the
error-counter-metrics
branch
from
4899915
to
04deddd
Compare
deshsidd
reviewed
Sep 19, 2024
src/main/java/org/opensearch/plugin/insights/core/metrics/OperationalMetricsCounter.java
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/metrics/OperationalMetric.java
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/metrics/OperationalMetric.java
Show resolved
Hide resolved
|
LGTM overall. Some minor comments |
|
@ansjcy Added some minor comments. Let me know your thoughts and we can get this merged |
Signed-off-by: Chenyang Ji <cyji@amazon.com>
ansjcy
force-pushed
the
error-counter-metrics
branch
from
04deddd
to
9b77411
Compare
deshsidd
approved these changes
Sep 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 38e84a2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Otel Counters to emit metrics to record number of errors in Query Insights plugin.
Issues Resolved
Related to #9
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.