Create health_stats API for query insights #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjcy
requested review from
jainankitk,
deshsidd and
dzane17
as code owners
|
The build will fail until we rebase #120 |
ansjcy
changed the title
ansjcy
force-pushed
the
health-api-for-qi
branch
2 times, most recently
from
ec73491
to
1d8e313
Compare
|
@deshsidd just rebased and this PR should be ready. |
deshsidd
reviewed
Sep 23, 2024
| @@ -114,13 +114,13 @@ public void testGetExecutorBuilders() { | |||
|
|
|||
| public void testGetRestHandlers() { | |||
| List<RestHandler> components = queryInsightsPlugin.getRestHandlers(Settings.EMPTY, null, null, null, null, null, null); | |||
| assertEquals(1, components.size()); | |||
| assertEquals(2, components.size()); | |||
| assertTrue(components.get(0) instanceof RestTopQueriesAction); | |||
There was a problem hiding this comment.
For the sake of completeness can verify that components.get(1) is as expected.
| assertTrue(components.get(0) instanceof RestTopQueriesAction); | ||
| } | ||
|
|
||
| public void testGetActions() { | ||
| List<ActionPlugin.ActionHandler<? extends ActionRequest, ? extends ActionResponse>> components = queryInsightsPlugin.getActions(); | ||
| assertEquals(1, components.size()); | ||
| assertEquals(2, components.size()); | ||
| assertTrue(components.get(0).getAction() instanceof TopQueriesAction); |
Signed-off-by: Chenyang Ji <cyji@amazon.com>
ansjcy
force-pushed
the
health-api-for-qi
branch
from
1d8e313
to
79379d9
Compare
|
LGTM |
deshsidd
approved these changes
Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit e4c6b8f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
added a commit
to ansjcy/query-insights
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com>
ansjcy
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create healthstats API for query insights, using the data model from #120
Issues Resolved
Related to #9
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.