Use separate targets for security enabled tests #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenyang Ji <cyji@amazon.com>
ansjcy
requested review from
jainankitk,
deshsidd and
dzane17
as code owners
deshsidd
approved these changes
Sep 10, 2024
|
Thanks, is this the reason why the ITs are failing? |
|
@deshsidd no, we need to look into the failures later, but it should be safe to disable them since we already have a dedicated target to run integration tests with security. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 839e6f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 839e6f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Sep 10, 2024
(cherry picked from commit 839e6f7) Signed-off-by: Chenyang Ji <cyji@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Sep 10, 2024
(cherry picked from commit 839e6f7) Signed-off-by: Chenyang Ji <cyji@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use separate targets for security enabled tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.