Refactor parsing logic for Measurement #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenyang Ji <cyji@amazon.com>
ansjcy
requested review from
jainankitk,
deshsidd and
dzane17
as code owners
Signed-off-by: Chenyang Ji <cyji@amazon.com>
|
LGTM |
deshsidd
approved these changes
Sep 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Refactor parsing logic for Measurement Signed-off-by: Chenyang Ji <cyji@amazon.com> * fix failed tests Signed-off-by: Chenyang Ji <cyji@amazon.com> --------- Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit b869de9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Refactor parsing logic for Measurement * fix failed tests --------- (cherry picked from commit b869de9) Signed-off-by: Chenyang Ji <cyji@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the path to parse a
MeasurementObject inSearchQueryRecordassumes measurement only has a Number value. Since we introduced aggregation in https://github.com/opensearch-project/query-insights/pull/66/files#diff-121513dc0c9407809aae27a6def385b2238c68e417b199cd1fe570220fc5c28cR23,Measurementnow is an Object withnumber,countandaggregation typefields. we need to refactor the parsing logic in all related paths.Issues Resolved
#107
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.