Add configuration section for exporter and delete_after #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjcy
force-pushed
the
exporter-configuration-section
branch
2 times, most recently
from
51da3cf to
4463e18
Compare
|
Do we need to show delete after status in the right side menu? When would the setting be disabled? The value is always 1-180. We could display that instead. |
dzane17
reviewed
Jan 22, 2025
| <h3>Delete After (days)</h3> | ||
| </EuiText> | ||
| <EuiText size="xs" style={textPadding}> | ||
| Delete the Query Insights data after certain days. |
There was a problem hiding this comment.
Something like Number of days to retain local index data
There was a problem hiding this comment.
Agree, might make more sense to display the number of days. If disabled, it seems like there is no retention period to the user which might not be the case.
There was a problem hiding this comment.
Might be good to get UX feedback on this
There was a problem hiding this comment.
Updated based on UX feedback
ansjcy
force-pushed
the
exporter-configuration-section
branch
from
1ca7e47 to
f8415bd
Compare
Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: Chenyang Ji <cyji@amazon.com>
ansjcy
force-pushed
the
exporter-configuration-section
branch
2 times, most recently
from
0649155 to
d071664
Compare
ansjcy
changed the title
Signed-off-by: Chenyang Ji <cyji@amazon.com>
ansjcy
force-pushed
the
exporter-configuration-section
branch
from
d071664 to
0da54ee
Compare
deshsidd
approved these changes
Jan 27, 2025
| @@ -23,7 +23,10 @@ describe('Query Group Details Page', () => { | |||
| // waiting for the query insights queue to drain | |||
| cy.wait(10000); | |||
| cy.navigateToOverview(); | |||
| cy.get('.euiTableRow').first().find('button').first().trigger('mouseover'); | |||
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
* Add configuration section for exporter and delete_after Signed-off-by: Chenyang Ji <cyji@amazon.com> * rebase from main and refactor functions Signed-off-by: Chenyang Ji <cyji@amazon.com> * exporter configruation pannels Signed-off-by: Chenyang Ji <cyji@amazon.com> * rebase main to pick up MDS changes Signed-off-by: Chenyang Ji <cyji@amazon.com> --------- Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 9f955a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Jan 27, 2025
* Add configuration section for exporter and delete_after * rebase from main and refactor functions * exporter configruation pannels * rebase main to pick up MDS changes --------- (cherry picked from commit 9f955a0) Signed-off-by: Chenyang Ji <cyji@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds configuration panels for
Query Insights Exporters
the newly added configuration endpoint
delete_after_daysTop N indices auto deletion config & functionality query-insights#172enabled
Issues Resolved
#47
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.