Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 8.5 #532

Closed
wants to merge 1 commit into from
Closed

Conversation

psychbot
Copy link
Member

@psychbot psychbot commented Feb 6, 2024

Fixing #530

Upgrading to gradle 8.5

Check List

  • Backport Labels added.
  • All tests pass
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70222ba) 74.44% compared to head (d0f617c) 74.43%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #532      +/-   ##
============================================
- Coverage     74.44%   74.43%   -0.01%     
+ Complexity     2667     2666       -1     
============================================
  Files           317      317              
  Lines         16378    16378              
  Branches       1282     1282              
============================================
- Hits          12192    12191       -1     
+ Misses         3671     3670       -1     
- Partials        515      517       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atharvasharma61
Copy link
Contributor

Need to backport these changes. @ansjcy Can you add the tags? We don't have the necessary permission.

Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
@reta
Copy link
Contributor

reta commented Feb 6, 2024

@psychbot there is already pull request open for that a few weeks ago #528

ansjcy
ansjcy previously approved these changes Feb 6, 2024
@ansjcy
Copy link
Member

ansjcy commented Feb 6, 2024

Let's use #528 since it already covered this change.

@psychbot
Copy link
Member Author

psychbot commented Feb 6, 2024

Marking this closed as #528 is merged.

@psychbot psychbot closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants