Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Handle Reader thread termination gracefully #482

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented Sep 7, 2023

Backport PR to #476

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #482 (dfcb909) into 2.x (a42e65e) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

❗ Current head dfcb909 differs from pull request most recent head 6835b6b. Consider uploading reports for the commit 6835b6b to get more accurate results

@@             Coverage Diff              @@
##                2.x     #482      +/-   ##
============================================
- Coverage     76.06%   75.70%   -0.37%     
+ Complexity     2586     2584       -2     
============================================
  Files           302      303       +1     
  Lines         15360    15418      +58     
  Branches       1213     1218       +5     
============================================
- Hits          11684    11672      -12     
- Misses         3185     3255      +70     
  Partials        491      491              
Files Changed Coverage Δ
...h/performanceanalyzer/LocalhostConnectionUtil.java 0.00% <0.00%> (ø)
...ch/performanceanalyzer/PerformanceAnalyzerApp.java 34.65% <0.00%> (-15.35%) ⬇️

... and 6 files with indirect coverage changes

@ansjcy ansjcy merged commit 943e6a3 into opensearch-project:2.x Sep 7, 2023
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 943e6a3)
khushbr added a commit that referenced this pull request Sep 8, 2023
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 943e6a3)

Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
@khushbr khushbr added the v2.11.0 Issues targeting release v2.11.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.10 v2.11.0 Issues targeting release v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants