Adding Maven publish WF #11

khushbr · 2023-05-23T19:39:01Z

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Adding Maven publish WF, following https://opensearch.org/blog/opensearch-plugin-zips-now-in-maven-repo/ and https://github.com/opensearch-project/opensearch-build/blob/main/ONBOARDING.md

% ./gradlew publishToMavenLocal
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
...
BUILD SUCCESSFUL in 1s
3 actionable tasks: 2 executed, 1 up-to-date

% ls /Users/khushbr/.m2/repository/org/opensearch/performance-analyzer-commons/1.0-SNAPSHOT
maven-metadata-local.xml			performance-analyzer-commons-1.0-SNAPSHOT.jar	performance-analyzer-commons-1.0-SNAPSHOT.pom

Following https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing, set url to /Users/khushbr/test/

% ls /Users/khushbr/test/org/opensearch/performance-analyzer-commons/1.0.0.0-SNAPSHOT
maven-metadata.xml							performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.sha256
maven-metadata.xml.md5							performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.sha512
maven-metadata.xml.sha1							performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom
maven-metadata.xml.sha256						performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.md5
maven-metadata.xml.sha512						performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.sha1
performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar		performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.sha256
performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.md5		performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.sha512
performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.sha1

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

gaiksaya · 2023-05-23T19:57:20Z

Can you testing the changes? See https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing for the steps

gaiksaya · 2023-05-23T19:57:48Z

.github/workflows/maven-publish.yml

+          export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text)
+          echo "::add-mask::$SONATYPE_USERNAME"
+          echo "::add-mask::$SONATYPE_PASSWORD"
+          ./gradlew publish


Should only publish to snapshots repository

khushbr · 2023-05-23T20:04:22Z

Can you testing the changes? See https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing for the steps

@gaiksaya Wondering how is this different from publishToMavenLocal ?

Following https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing, set url to
/Users/khushbr/test/


% ls /Users/khushbr/test/org/opensearch/performance-analyzer-commons/1.0-SNAPSHOT
maven-metadata.xml						performance-analyzer-commons-1.0-20230523.200158-1.jar		performance-analyzer-commons-1.0-20230523.200158-1.pom
maven-metadata.xml.md5						performance-analyzer-commons-1.0-20230523.200158-1.jar.md5	performance-analyzer-commons-1.0-20230523.200158-1.pom.md5
maven-metadata.xml.sha1						performance-analyzer-commons-1.0-20230523.200158-1.jar.sha1	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha1
maven-metadata.xml.sha256					performance-analyzer-commons-1.0-20230523.200158-1.jar.sha256	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha256
maven-metadata.xml.sha512					performance-analyzer-commons-1.0-20230523.200158-1.jar.sha512	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha512

gaiksaya · 2023-05-23T20:08:26Z

Can you testing the changes? See https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing for the steps

@gaiksaya Wondering how is this different from publishToMavenLocal ?

Following https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing, set url to /Users/khushbr/test/


% ls /Users/khushbr/test/org/opensearch/performance-analyzer-commons/1.0-SNAPSHOT
maven-metadata.xml						performance-analyzer-commons-1.0-20230523.200158-1.jar		performance-analyzer-commons-1.0-20230523.200158-1.pom
maven-metadata.xml.md5						performance-analyzer-commons-1.0-20230523.200158-1.jar.md5	performance-analyzer-commons-1.0-20230523.200158-1.pom.md5
maven-metadata.xml.sha1						performance-analyzer-commons-1.0-20230523.200158-1.jar.sha1	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha1
maven-metadata.xml.sha256					performance-analyzer-commons-1.0-20230523.200158-1.jar.sha256	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha256
maven-metadata.xml.sha512					performance-analyzer-commons-1.0-20230523.200158-1.jar.sha512	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha512

Maven local also has generates different kind of metadata.xml. Also above artifacts are missing "SNAPSHOTS" keyword which might lead to failures during upload

…Repository Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

khushbr · 2023-05-23T20:32:50Z

Can you testing the changes? See https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing for the steps

@gaiksaya Wondering how is this different from publishToMavenLocal ?
Following https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing, set url to /Users/khushbr/test/
% ls /Users/khushbr/test/org/opensearch/performance-analyzer-commons/1.0-SNAPSHOT
maven-metadata.xml						performance-analyzer-commons-1.0-20230523.200158-1.jar		performance-analyzer-commons-1.0-20230523.200158-1.pom
maven-metadata.xml.md5						performance-analyzer-commons-1.0-20230523.200158-1.jar.md5	performance-analyzer-commons-1.0-20230523.200158-1.pom.md5
maven-metadata.xml.sha1						performance-analyzer-commons-1.0-20230523.200158-1.jar.sha1	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha1
maven-metadata.xml.sha256					performance-analyzer-commons-1.0-20230523.200158-1.jar.sha256	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha256
maven-metadata.xml.sha512					performance-analyzer-commons-1.0-20230523.200158-1.jar.sha512	performance-analyzer-commons-1.0-20230523.200158-1.pom.sha512
Maven local also has generates different kind of metadata.xml. Also above artifacts are missing "SNAPSHOTS" keyword which might lead to failures during upload

Thank you clarifying, @gaiksaya . Fixed the issue.

gaiksaya · 2023-05-23T21:31:26Z

Thanks! Can you also update the comment with new snaphots that are being published? Also, just confirming org.opensearch.performance-analyzer-commons is the right maven coordinates right?
Adding @prudhvigodithi for one more pair of eyes

prudhvigodithi · 2023-05-23T21:50:04Z

Does this plugin also generate a Zip file to install apart from the jar? As did notice the following is commented out

distZip {
    archiveName "performance-analyzer-commons-${version}.zip"
}

@khushbr

khushbr · 2023-05-23T21:52:29Z

Thanks! Can you also update the comment with new snaphots that are being published? Also, just confirming org.opensearch.performance-analyzer-commons is the right maven coordinates right? Adding @prudhvigodithi for one more pair of eyes

@gaiksaya The PR description has been updated with the latest snpashots getting published. Adding here as well.

And yes, org.opensearch.performance-analyzer-commons is the right maven location.

% ls /Users/khushbr/test/org/opensearch/performance-analyzer-commons/1.0.0.0-SNAPSHOT
maven-metadata.xml							performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.sha256
maven-metadata.xml.md5							performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.sha512
maven-metadata.xml.sha1							performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom
maven-metadata.xml.sha256						performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.md5
maven-metadata.xml.sha512						performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.sha1
performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar		performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.sha256
performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.md5		performance-analyzer-commons-1.0.0.0-20230523.202721-1.pom.sha512
performance-analyzer-commons-1.0.0.0-20230523.202721-1.jar.sha1

khushbr · 2023-05-23T21:53:55Z

Does this plugin also generate a Zip file to install apart from the jar? As did notice the following is commented out
distZip {
    archiveName "performance-analyzer-commons-${version}.zip"
}
@khushbr

@prudhvigodithi Only the source JAR is required from commons. Curious, any reason to publish a zip here that you are aware?

prudhvigodithi · 2023-05-23T21:56:39Z

Got it, plugins can be installed with zip file, so we are publishing the plugin zips also to maven along with jars, please check https://opensearch.org/blog/opensearch-plugin-zips-now-in-maven-repo/.

khushbr added 2 commits May 23, 2023 12:04

Adding Maven publish WF

bae2ad7

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

Removing OpenSearch Dependency in build.gradle

96352e8

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

khushbr requested review from praveensameneni, ansjcy, goyamegh, getsaurabh02, sbcd90 and sgup432 as code owners May 23, 2023 19:39

Updating bcel version to handle CVE-2022-42920

160e898

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

gaiksaya reviewed May 23, 2023

View reviewed changes

Updating maven-publish.yml to use publishShadowPublicationToSnapshots…

2509ae5

…Repository Signed-off-by: Khushboo Rajput <khushbr@amazon.com>

gaiksaya mentioned this pull request May 23, 2023

[release]: performance-analyzer-commons opensearch-project/opensearch-build#3547

Closed

khushbr merged commit 0df56b0 into opensearch-project:main May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Maven publish WF #11

Adding Maven publish WF #11

khushbr commented May 23, 2023 •

edited

Loading

gaiksaya commented May 23, 2023

gaiksaya May 23, 2023

khushbr commented May 23, 2023

gaiksaya commented May 23, 2023

khushbr commented May 23, 2023

gaiksaya commented May 23, 2023

prudhvigodithi commented May 23, 2023 •

edited

Loading

khushbr commented May 23, 2023

khushbr commented May 23, 2023

prudhvigodithi commented May 23, 2023

Adding Maven publish WF #11

Adding Maven publish WF #11

Conversation

khushbr commented May 23, 2023 • edited Loading

Check List

gaiksaya commented May 23, 2023

gaiksaya May 23, 2023

Choose a reason for hiding this comment

khushbr commented May 23, 2023

gaiksaya commented May 23, 2023

khushbr commented May 23, 2023

gaiksaya commented May 23, 2023

prudhvigodithi commented May 23, 2023 • edited Loading

khushbr commented May 23, 2023

khushbr commented May 23, 2023

prudhvigodithi commented May 23, 2023

khushbr commented May 23, 2023 •

edited

Loading

prudhvigodithi commented May 23, 2023 •

edited

Loading