Make font consumption happen using CSS variables #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-font-family` and `--oui-code-font-family` CSS variables Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
seanneumann,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
BSFishy
reviewed
Jun 19, 2023
BSFishy
approved these changes
Jun 19, 2023
bandinib-amzn
approved these changes
Jun 19, 2023
manasvinibs
reviewed
Jun 19, 2023
| @@ -62,7 +62,7 @@ | |||
|
|
|||
| .ouiSuggestItem__label { | |||
| @include ouiTextTruncate; | |||
| font-family: $ouiCodeFontFamily; | |||
| font-family: var(--oui-code-font-family); | |||
There was a problem hiding this comment.
I don't see any issues tagged to the PR. Trying to understand the purpose behind this change. Why are we changing from sass to css variables?
There was a problem hiding this comment.
CSS variables will allow overriding them on the frontend, without having to load a new stylesheet: faster iterations.
BSFishy
pushed a commit
that referenced
this pull request
Jun 20, 2023
…i-font-family` and `--oui-code-font-family` CSS variables (#814) (#821) (cherry picked from commit a0e0bb5) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace usage of
$ouiFontFamilyand$ouiCodeFontFamilywith--oui-font-familyand--oui-code-font-familyCSS variablesIssues Resolved
[List any issues this PR will resolve]
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.