[OUI] Removed figma link/icon, Codesandbox link/icon, Sketch link/icon Casc… #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adia options from the theme dropdown Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
KrooshalUX
previously approved these changes
Dec 27, 2022
BSFishy
suggested changes
Dec 30, 2022
Comment on lines
-133
to
-135
| <GuideSketchLink /> | ||
| <GuideFigmaLink /> | ||
| {renderCodeSandbox()} |
There was a problem hiding this comment.
Are these components used anywhere else? If not, can the components themselves be deleted?
Comment on lines
-48
to
-49
| onToggleLocale, | ||
| selectedLocale, |
There was a problem hiding this comment.
If these props aren't being used anymore, can they be removed from the props interface?
6 tasks
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
BSFishy
approved these changes
Jan 4, 2023
ashwin-pc
reviewed
Jan 4, 2023
|
@ashwin-pc because we cannot support it right now - please see the original task in the issue #111 was to "Remove Babelfish (comment out pending further testing and localization strategy)" |
ashwin-pc
approved these changes
Jan 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
…n Casc… (#164) * Removed figma link/icon, Codesandbox link/icon, Sketch link/icon Cascadia options from the theme dropdown Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Deleted guidefigmalink and guidesketch link Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> (cherry picked from commit 849d086)
BSFishy
pushed a commit
that referenced
this pull request
Jan 6, 2023
…n Casc… (#164) (#201) * Removed figma link/icon, Codesandbox link/icon, Sketch link/icon Cascadia options from the theme dropdown Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> * Deleted guidefigmalink and guidesketch link Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> (cherry picked from commit 849d086) Co-authored-by: Abhishek Reddy <62020972+AbhishekReddy1127@users.noreply.github.com>
joshuarrrr
added a commit
to joshuarrrr/oui
that referenced
this pull request
Nov 14, 2023
Remove vestiges of CodeSandbox integration as follow-up to opensearch-project#164 Add resolution for `wait-on` Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
added a commit
to joshuarrrr/oui
that referenced
this pull request
Nov 14, 2023
Remove vestiges of CodeSandbox integration as follow-up to opensearch-project#164 Add resolution for `wait-on` Signed-off-by: Josh Romero <rmerqg@amazon.com>
7 tasks
joshuarrrr
added a commit
to joshuarrrr/oui
that referenced
this pull request
Nov 14, 2023
Remove vestiges of CodeSandbox integration as follow-up to opensearch-project#164 Add resolution for `wait-on` Signed-off-by: Josh Romero <rmerqg@amazon.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Feb 2, 2024
…links (#1152) * [Security] Remediate `axios` vulnerabilities Remove vestiges of CodeSandbox integration as follow-up to #164 Add resolution for `wait-on` Signed-off-by: Josh Romero <rmerqg@amazon.com> * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * restore unintentionally removed guide section code tab Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
…links (#1152) * [Security] Remediate `axios` vulnerabilities Remove vestiges of CodeSandbox integration as follow-up to #164 Add resolution for `wait-on` Signed-off-by: Josh Romero <rmerqg@amazon.com> * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * restore unintentionally removed guide section code tab Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 077a7b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Feb 2, 2024
…links (#1152) (#1230) * [Security] Remediate `axios` vulnerabilities Remove vestiges of CodeSandbox integration as follow-up to #164 Add resolution for `wait-on` Signed-off-by: Josh Romero <rmerqg@amazon.com> * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * restore unintentionally removed guide section code tab Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 077a7b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AbhishekReddy1127 nallamsa@amazon.com
Description
Removed Figma, Codesandbox, Sketch link and icon.
Removed Cascadia options and Babelfish from theme dropdown.
Issues Resolved
Fixes #111
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.