feat: Add V9 Theme #1344
Merged
feat: Add V9 Theme #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
virajsanghvi
requested review from
AMoo-Miki,
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
|
Note: failing test looks unrelated (due to a workspace issue) |
AMoo-Miki
approved these changes
Aug 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
* feat: Add V9 Theme Signed-off-by: Viraj Sanghvi <virajs@amazon.com> * update changelog Signed-off-by: Viraj Sanghvi <virajs@amazon.com> * update colors and typography Signed-off-by: Viraj Sanghvi <virajs@amazon.com> --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> (cherry picked from commit a45811b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 16, 2024
* feat: Add V9 Theme * update changelog * update colors and typography --------- (cherry picked from commit a45811b) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces a new Theme, temporarily named V9. This is a work in progress, but putting out a PR so we can start testing it against OSD.
Most of this was copied from oui-next, but changes include:
Main risk with these theme at the moment are header font sizes as they render at a different size than v7/v8 counterparts.
Screenshot:
Issues Resolved
N/A
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.