Fix datagrid lines #1250
Merged
Fix datagrid lines #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
main-grid-lines
branch
from
b6dc1d5
to
f2de7a7
Compare
bandinib-amzn
approved these changes
Feb 9, 2024
| @@ -190,6 +175,23 @@ | |||
| transition: none; // Have to take out the generic transition so it is instantaneous on focus | |||
| } | |||
|
|
|||
| &__expandButtonIcon { | |||
| box-shadow: none !important; // sass-lint:disable-line no-important | |||
There was a problem hiding this comment.
nit: Do we need this commented code?
ashwin-pc
approved these changes
Feb 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 543435a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 543435a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Feb 9, 2024
AMoo-Miki
pushed a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 543435a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bad merge from a cherry-pick
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.