Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next Theme] Set base font size to 18px #1221

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Jan 31, 2024

Description

Since the text font for the Next theme has a smaller appearance, a larger font-size is employed.

PS, this will probably need some followups to fine tune other areas.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Miki <miki@amazon.com>
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd ask for screenshots and such, but since this is localized to next theme, I'm alright with pushing it through and iterating quickly

@AMoo-Miki
Copy link
Collaborator Author

Normally I'd ask for screenshots and such, but since this is localized to next theme, I'm alright with pushing it through and iterating quickly

Matt, i have this hosted. There is certainly more to do for this and I have just tackled a few of the obvious ones.

@AMoo-Miki AMoo-Miki merged commit 15ab240 into opensearch-project:main Feb 1, 2024
15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 2, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 15ab240)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
AMoo-Miki pushed a commit that referenced this pull request Feb 2, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 15ab240)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants