Implemented Cache for Unreleased OpenSearch images #154
Conversation
Signed-off-by: Theo Truong <theotr@amazon.com>
nhtruong
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock,
VachaShah and
harshavamsi
as code owners
| - name: opensearch-api | ||
| run: cd opensearch-api && bundle exec rake test:spec | ||
| working-directory: ruby-client/opensearch-api | ||
| run: bundle exec rake test:spec |
There was a problem hiding this comment.
For another time, we should probably make this test:all as well.
There was a problem hiding this comment.
test:all will also include unit tests with mocked transport layer, which doesn't hit the OS cluster that we setup for each Matrix entry. Wouldn't that be redundant for this workflow where we focus on integration tests of different unreleased versions of OS?
There was a problem hiding this comment.
It would. I still think it's mental overhead, maybe there's a better solution. Either way it's NBD.
| @@ -53,14 +87,32 @@ jobs: | |||
| ruby -v | |||
| rake bundle:clean | |||
| rake bundle:install | |||
| working-directory: ruby-client | |||
|
|
|||
| - name: opensearch-ruby | |||
There was a problem hiding this comment.
For another time, make we can have a top level Rakefile to build and test, since I don't think we want gemspecs that are wildly incompatible across these gems anyway?
There was a problem hiding this comment.
We have to working-directory: ruby-client because the client was cloned into ruby-client folder to avoid collision with the opensearch repo that is also being pulled into the same machine. We do have a top level Rakefile and Gemfile.
Description
Reduce
unreleased integration testsworkflow runtimeIssues Resolved
closes #144
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.