Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping pandas version from 1.5.0 to 2.x #373

Closed
wants to merge 7 commits into from

Conversation

Yerzhaisang
Copy link
Contributor

Description

Fix all issues when pandas is upgraded from 1.5.0 to 2.x

Issues Resolved

#270

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yerzhaisang
Copy link
Contributor Author

Yerzhaisang commented Feb 12, 2024

Dear @dhrubo-os, this is just draft PR. I replaced deprecated mad method in pandas 2.x.x with custom function.
I continue to fix other deprecated methods in pandas 2.x.x

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0b1bcf) 91.53% compared to head (35e3fb1) 91.53%.

❗ Current head 35e3fb1 differs from pull request most recent head 26884b7. Consider uploading reports for the commit 26884b7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          42       42           
  Lines        4395     4395           
=======================================
  Hits         4023     4023           
  Misses        372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os
Copy link
Collaborator

Let's take all the updates from main.

Signed-off-by: Yerzhaisang <tasqali1697@gmail.com>
Signed-off-by: Yerzhaisang <tasqali1697@gmail.com>
….x.x and fixed quantile keyword argument

Signed-off-by: Yerzhaisang <tasqali1697@gmail.com>
Signed-off-by: Yerzhaisang <tasqali1697@gmail.com>
Signed-off-by: Yerzhaisang <tasqali1697@gmail.com>
Signed-off-by: Yerzhaisang <tasqali1697@gmail.com>
Signed-off-by: Yerzhaisang <tasqali1697@gmail.com>
@dhrubo-os
Copy link
Collaborator

looks like integration tests are failing.

@Yerzhaisang
Copy link
Contributor Author

looks like integration tests are failing.

Yeah, I will let you know when it's fixed

@dhrubo-os
Copy link
Collaborator

@Yerzhaisang are you still working on this issue?

@Yerzhaisang Yerzhaisang closed this by deleting the head repository Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants