-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Wrap Up Profile API #285
Comments
I'll try my hand at this issue. |
Thanks, assigned it to you. |
@dhrubo-os , I will be working on this issue. Thanks |
Thanks, assigned to you. @rawwar |
@dhrubo-os , When I search for tasks using the following query, i get a lot of results.
One of the hits is as below
Now, when I try to get tasks using profile, i get nothing. Query:
Result
I tried giving I also tried to use the task id from the above search result and its still an empty result
Result:
Am i doing anything wrong here? |
Returns runtime data for a specific task. You can string together multiple task_ids to return multiple task profiles So I think, tasks are completed and not available in the memory? |
I interpreted this line as some runtime logs available for viewing at a later point. Reason being, for model profile, all of the model tasks are complete and they are returned as well. |
I am not sure how we can test this. Since tests don't run in parallel, there's no way to test this if its in-progress data. I'll just ensure an OK response. Is that ok? |
Yup, that should be fine for now. |
Those models tasks persisted in the index, so you can see. But for the profile api, we look into the memory. That's why outpout is different. |
@dhrubo-os , one information I could not get from documentation is the minimum OpenSearch version required for this API. Tests are successfully running for 2.7 and 2.11 for now. Hence, i haven't added any minimum version requirements for these tests |
We can keep min version as 2.7 for now. That should be fine. |
* init Signed-off-by: kalyanr <kalyan.ben10@live.com> * update changelog Signed-off-by: kalyanr <kalyan.ben10@live.com> * update Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix Signed-off-by: kalyanr <kalyan.ben10@live.com> * lint fix Signed-off-by: kalyanr <kalyan.ben10@live.com> * reuse validate input Signed-off-by: kalyanr <kalyan.ben10@live.com> * update comment Signed-off-by: kalyanr <kalyan.ben10@live.com> * change Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix Signed-off-by: kalyanr <kalyan.ben10@live.com> * update changelog Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix Signed-off-by: kalyanr <kalyan.ben10@live.com> * remove separate model profile module Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix tests Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix lint Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix lint Signed-off-by: kalyanr <kalyan.ben10@live.com> * fix Signed-off-by: kalyanr <kalyan.ben10@live.com> * Update ml_commons_client.py Signed-off-by: Kalyan <kalyan.ben10@live.com> --------- Signed-off-by: kalyanr <kalyan.ben10@live.com> Signed-off-by: Kalyan <kalyan.ben10@live.com>
Is your feature request related to a problem?
We started building Profile API in opensearch-py-ml repo: PR : #119
We need to wrap up this PR with adding unit test and further development (if needed) with addressing the comments.
The text was updated successfully, but these errors were encountered: