[Add] add a changelog item.

Signed-off-by: conggguan <congguan@amazon.com>
opensearch-project · Aug 9, 2024 · fdabdf4 · fdabdf4
1 parent 7c94820
commit fdabdf4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/.ci/run-repository.sh b/.ci/run-repository.sh
@@ -96,7 +96,7 @@ elif [[ "$TASK_TYPE" == "SentenceTransformerTrace" || "$TASK_TYPE" == "SparseTra
   --env "TEST_TYPE=server" \
   --name opensearch-py-ml-trace-runner \
   opensearch-project/opensearch-py-ml \
-  nox -s "${NOX_TRACE_TYPE}-${PYTHON_VERSION}" -- ${MODEL_ID} ${MODEL_VERSION} ${TRACING_FORMAT} ${UPLOAD_PREFIX} ${EXTRA_ARGS} -md ${MODEL_DESCRIPTION:+"$MODEL_DESCRIPTION"}
+  nox -s "${NOX_TRACE_TYPE}-${PYTHON_VERSION}" -- ${MODEL_ID} ${MODEL_VERSION} ${TRACING_FORMAT} ${EXTRA_ARGS} -up ${UPLOAD_PREFIX} -md ${MODEL_DESCRIPTION:+"$MODEL_DESCRIPTION"}
 
   # To upload a model, we need the model artifact, description, license files into local path
   # trace_output should include description and license file.

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -46,6 +46,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - updating listing file with three v2 sparse model - by @dhrubo-os ([#412](https://github.com/opensearch-project/opensearch-py-ml/pull/412))
 
 ### Fixed
+- Fix the wrong final zip file name in model_uploader workflow, now will name it by the upload_prefix alse.([#413](https://github.com/opensearch-project/opensearch-py-ml/pull/413/files))
 - Fix the wrong input parameter for model_uploader's base_download_path in jekins trigger.([#402](https://github.com/opensearch-project/opensearch-py-ml/pull/402))
 - Enable make_model_config_json to add model description to model config file by @thanawan-atc in ([#203](https://github.com/opensearch-project/opensearch-py-ml/pull/203))
 - Correct demo_ml_commons_integration.ipynb by @thanawan-atc in ([#208](https://github.com/opensearch-project/opensearch-py-ml/pull/208))

diff --git a/utils/model_uploader/model_autotracing.py b/utils/model_uploader/model_autotracing.py
@@ -428,8 +428,11 @@ def main(
         help="Model format for auto-tracing",
     )
     parser.add_argument(
-        "upload_prefix",
+        "-up",
+        "--upload_prefix",
         type=str,
+        nargs="?",
+        default=None,
         help="Model customize path prefix for upload",
     )
     parser.add_argument(

diff --git a/utils/model_uploader/sparse_model_autotracing.py b/utils/model_uploader/sparse_model_autotracing.py
@@ -331,8 +331,11 @@ def main(
         help="Model format for auto-tracing",
     )
     parser.add_argument(
-        "upload_prefix",
+        "-up",
+        "--upload_prefix",
         type=str,
+        nargs="?",
+        default=None,
         help="Model customize path prefix for upload",
     )
     parser.add_argument(