Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary workflow steps #71

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Jun 6, 2024

Description

Remove unnecessary workflow steps

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@@ -35,8 +35,3 @@ jobs:
./gradlew build
# Generated by 'opensearch.pluginzip' custom gradle plugin
./gradlew publishPluginZipPublicationToZipStagingRepository
- name: Update version to the next development iteration
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we build against 3.x, no next development iteration yet

@dblock dblock merged commit 2ddf039 into opensearch-project:main Jun 7, 2024
8 checks passed
@rursprung
Copy link
Contributor

@reta: shouldn't the same be done for 2.x then?
the step is also useless there as it won't build it against the snapshot and it won't store this anywhere, from what i can see...

@reta
Copy link
Collaborator Author

reta commented Jun 11, 2024

@reta: shouldn't the same be done for 2.x then?
the step is also useless there as it won't build it against the snapshot and it won't store this anywhere, from what i can see...

I think for 2.x we would need to change workflow step a bit to make it useful, I will take care of it shortly, thank you @rursprung !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants