-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated search function documentation #108
updated search function documentation #108
Conversation
Signed-off-by: Harrowmykel <aromicheal@piccmaq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sign the DCO?
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage ? 26.96%
Complexity ? 1934
=======================================
Files ? 245
Lines ? 5544
Branches ? 0
=======================================
Hits ? 1495
Misses ? 4049
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yes, i signed it |
Kindly consider making it easier to contribute to this open-sourced project. Why do we have to provide our personal email to a public repository before we can contribute? We should be able to sign with our username instead. I am not making any further changes to this project, if I have to keep providing my email. You can close this merge request if you don't want my contributions because of this. |
@mo-aro-etailer Thanks, we chose DCO as the most minimal way to protect downstream users (over for example CLA). I encourage you to read https://github.com/opensearch-project/opensearch-php/blob/main/CONTRIBUTING.md#developer-certificate-of-origin. |
Anyone looking in to this PR? @dblock @shyim @harrowmykel |
Sorry about this, @harrowmykel could you please rebase it? I'll be happy to merge. |
@shyim Client.asciidoc is gone on main, should this one be closed? |
yes can be closed |
@shyim please don't hesitate to also click the close and merge buttons! :) |
Description
search(array $params = []) function does not show the following. so I added it
Issues Resolved
#101