Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated search function documentation #108

Conversation

harrowmykel
Copy link
Contributor

Description

search(array $params = []) function does not show the following. so I added it

/*
* $params['stats']                         = (list) Specific 'tag' of the request for logging and statistical purposes
     * $params['suggest_field']                 = (string) Specify which field to use for suggestions
     * $params['suggest_mode']                  = (enum) Specify suggest mode (Options = missing,popular,always) (Default = missing)
     * $params['suggest_size']                  = (number) How many suggestions to return in response
     * $params['suggest_text']                  = (string) The source text for which the suggestions should be returned
     * $params['timeout']                       = (time) Explicit operation timeout
     * $params['track_scores']                  = (boolean) Whether to calculate and return scores even if they are not used for sorting
     * $params['track_total_hits']              = (boolean) Indicate if the number of documents that match the query should be tracked
     * $params['allow_partial_search_results']  = (boolean) Indicate if an error should be returned if there is a partial search failure or timeout (Default = true)
     * $params['typed_keys']                    = (boolean) Specify whether aggregation and suggester names should be prefixed by their respective types in the response
     * $params['version']                       = (boolean) Specify whether to return document version as part of a hit
     * $params['seq_no_primary_term']           = (boolean) Specify whether to return sequence number and primary term of the last modification of each hit
     * $params['request_cache']                 = (boolean) Specify if request cache should be used for this request or not, defaults to index level setting
     * $params['batched_reduce_size']           = (number) The number of shard results that should be reduced at once on the coordinating node. This value should be used as a protection mechanism to reduce the memory overhead per search request if the potential number of shards in the request can be large. (Default = 512)
     * $params['max_concurrent_shard_requests'] = (number) The number of concurrent shard requests per node this search executes concurrently. This value should be used to limit the impact of the search on the cluster in order to limit the number of concurrent shard requests (Default = 5)
     * $params['pre_filter_shard_size']         = (number) A threshold that enforces a pre-filter roundtrip to prefilter search shards based on query rewriting if the number of shards the search request expands to exceeds the threshold. This filter roundtrip can limit the number of shards significantly if for instance a shard can not match any documents based on its rewrite method ie. if date filters are mandatory to match but the shard bounds and the query are disjoint.
     * $params['rest_total_hits_as_int']        = (boolean) Indicates whether hits.total should be rendered as an integer or an object in the rest search response (Default = false)
     * $params['body']
     * @param array $params Associative array of parameters
     * @return array
     * 
     * */
    

Issues Resolved

#101

Signed-off-by: Harrowmykel <aromicheal@piccmaq.com>
Copy link
Collaborator

@shyim shyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign the DCO?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@cf91bd8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage        ?   26.96%           
  Complexity      ?     1934           
=======================================
  Files           ?      245           
  Lines           ?     5544           
  Branches        ?        0           
=======================================
  Hits            ?     1495           
  Misses          ?     4049           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@harrowmykel
Copy link
Contributor Author

Yes, i signed it

@mo-aro-etailer
Copy link

Kindly consider making it easier to contribute to this open-sourced project. Why do we have to provide our personal email to a public repository before we can contribute? We should be able to sign with our username instead.

I am not making any further changes to this project, if I have to keep providing my email. You can close this merge request if you don't want my contributions because of this.

@dblock
Copy link
Member

dblock commented Jan 8, 2023

@mo-aro-etailer Thanks, we chose DCO as the most minimal way to protect downstream users (over for example CLA). I encourage you to read https://github.com/opensearch-project/opensearch-php/blob/main/CONTRIBUTING.md#developer-certificate-of-origin.

@bbarani
Copy link
Member

bbarani commented Sep 25, 2023

Anyone looking in to this PR? @dblock @shyim @harrowmykel

@dblock
Copy link
Member

dblock commented Sep 26, 2023

Sorry about this, @harrowmykel could you please rebase it? I'll be happy to merge.

@dblock
Copy link
Member

dblock commented Apr 19, 2024

@shyim Client.asciidoc is gone on main, should this one be closed?

@shyim
Copy link
Collaborator

shyim commented Apr 19, 2024

yes can be closed

@dblock
Copy link
Member

dblock commented Apr 19, 2024

@shyim please don't hesitate to also click the close and merge buttons! :)

@dblock dblock closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants