Add changelog and changelog verifier #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavamsi
requested review from
anirudha,
dblock,
joshuali925,
Xtansia,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
harshavamsi
force-pushed
the
feature/changelog
branch
from
73546ff
to
fc1213f
Compare
Yury-Fridlyand
previously approved these changes
Oct 14, 2022
Xtansia
requested changes
Oct 14, 2022
|
Good catch @Xtansia. I have more in opensearch-project/opensearch-go#172. |
harshavamsi
force-pushed
the
feature/changelog
branch
from
fc1213f
to
ccdb9b1
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
feature/changelog
branch
from
ccdb9b1
to
6c194f0
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
dblock
approved these changes
Oct 20, 2022
Yury-Fridlyand
approved these changes
Oct 20, 2022
VachaShah
approved these changes
Oct 20, 2022
|
@Xtansia you good with this? |
Xtansia
reviewed
Oct 21, 2022
| ## Overview | ||
|
|
||
| This document explains who the maintainers are (see below), what they do in this repo, and how they should be doing it. If you're interested in contributing, see [CONTRIBUTING](CONTRIBUTING.md). | ||
| [This document](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#maintainer-responsibilities) explains who the maintainers are (see below), what they do in this repo, and how they should be doing it. If you're interested in contributing, see [CONTRIBUTING](CONTRIBUTING.md). |
There was a problem hiding this comment.
Saying "This document" linking to another document, while explaining the contents of the current document and the linked one is somewhat confusing. I think it'd be better to rephrase this to something like This document lists the current maintainers of this repository. An explanation of what they do and their responsibilities can be found in the [central opensearch project MAINTAINERS file]
There was a problem hiding this comment.
I hit merge - this is a valid comment though, we have this language all over the place. Something to add to a template ...
Xtansia
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri harshavamsi096@gmail.com
Description
Introduces changelog and changelog verifier.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.