This repository has been archived by the owner on Sep 17, 2022. It is now read-only.
Update nuget packages #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
MaxKsyunz
approved these changes
Aug 25, 2022
This was referenced Aug 25, 2022
joshuali925
approved these changes
Aug 26, 2022
dblock
suggested changes
Aug 26, 2022
There was a problem hiding this comment.
I see some unexpected things looking carefully at https://github.com/opensearch-project/opensearch-net-abstractions/pull/19/files?w=1
| SkipReason = skipReason ?? "skipped"; | ||
|
|
||
| public int Timeout => 0; |
There was a problem hiding this comment.
This looks new, why was it added?
There was a problem hiding this comment.
xunit was updated and interface TestMethodTestCase got a new method Timeout which should be overloaded.
| @@ -7,7 +7,9 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="SemanticVersioning" Version="0.8.0" /> | |||
| <PackageReference Include="System.Text.Json" Version="4.6.0" /> | |||
| <PackageReference Include="System.Net.Http" Version="4.3.4" /> | |||
| <PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" /> | |||
There was a problem hiding this comment.
These are essential packages, compilation fails without them.
I'm also surprised how it was working before.
dblock
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com
Description
Update some Nuget packages which had dependencies with critical CVEs reported.
See opensearch-project/opensearch-net#88 for more info about security update.
Issues Resolved
CVE-2021-26701inSystem.Text.Encodings.WebBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.