-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced docker-compose
with docker compose
in Makefile
#848
Conversation
Locking Gradle version to 8.9 Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not lose tests against 1.x. Add the JDK version to the matrix and install that one instead of 17.
@dblock Got it. Should we we remove that for 3.x client as its generated API no longer accept |
If we do remove 1.x support then yes. I would take a hard look at the possibility of preserving 1.x support though because a very large number of users are still on 1.x and we would love for them to upgrade. |
Signed-off-by: Theo Truong <theotr@amazon.com> # Active mechanism to check for cluster readiness
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
@dblock all issues resolved. I also replaced |
closes #845
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.