Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Coverage Upload fail_ci_if_error #756

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

nhtruong
Copy link
Collaborator

Description

Resolving missing token error in codecov-action

Issues Resolved

closes #755

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Apr 15, 2024

This failed with

[2024-04-15T18:08:38.245Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

@nhtruong nhtruong changed the title Made codecov-action use OICD instead of a token Disabled Coverage Upload fail_ci_if_error Apr 18, 2024
@nhtruong
Copy link
Collaborator Author

@dblock This should do it for now. As mentioned in #755, the coverage still runs and will fail if coverage fails to meet a certain threshold. It's the upload step to codecov.com that failed but we can ignore this failure like our other node.js repos. When we do have a need to upload the coverage, we will add a token like discovered in #755. This PR will unblock other PRs.

Upgraded codecov-action from v2 to v4

Signed-off-by: Theo Truong <theotr@amazon.com>
@dblock dblock merged commit 1138ed8 into opensearch-project:main Apr 19, 2024
64 checks passed
@nhtruong nhtruong deleted the codecove/OIDC branch June 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Code coverage is failing to upload on dependabot PRs
2 participants