Http namespace #649
Merged
Http namespace #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtruong
force-pushed
the
http_namespace
branch
6 times, most recently
from
dd8aa9c
to
cfb6cba
Compare
nhtruong
force-pushed
the
http_namespace
branch
2 times, most recently
from
464f9cd
to
1707171
Compare
nhtruong
requested review from
ananzh,
kavilla,
seanneumann,
VachaShah,
harshavamsi and
timursaurus
as code owners
dblock
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Looking good, some asks below. Can we also start adding working samples like in https://github.com/opensearch-project/opensearch-py/tree/main/samples with this one?
- Removed fixtures wrongly flagged by git-secrets for containing passwords/secrets Signed-off-by: Theo Truong <theotr@amazon.com>
nhtruong
force-pushed
the
http_namespace
branch
from
1707171
to
0f39b6f
Compare
dblock
approved these changes
Nov 28, 2023
| @@ -5,6 +5,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ## [Unreleased] | |||
| ### Added | |||
| - Added deprecation warnings for Index Template APIs ([654](https://github.com/opensearch-project/opensearch-js/pull/645)) | |||
| - Added `http` functions: `connect`, `delete`, `get`, `head`, `options`, `patch`, `post`, `put`, and `trace` ([#649](https://github.com/opensearch-project/opensearch-js/pull/649)) | |||
There was a problem hiding this comment.
Nit: Added http.connect, delete ...
| @@ -0,0 +1,60 @@ | |||
| # Making raw HTTP requests | |||
There was a problem hiding this comment.
Capitalize like other files, "Making Raw HTTP Requests"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Low Level API functions
Removed fixtures flagged by
git-secretsfor containing passwords/secretsIssues Resolved
Closes #631
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.