[CCI] BaseConnectionPool missing implementation of markAlive and markDead methods
#430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timursaurus
requested review from
ananzh,
kavilla,
seanneumann,
dblock,
VachaShah,
nhtruong and
harshavamsi
as code owners
timursaurus
changed the title
BaseConnectionPool missing implementation of markAlive and markDead methodsBaseConnectionPool missing implementation of markAlive and markDead methods
dblock
requested changes
Mar 12, 2023
CHANGELOG.md
Outdated
| @@ -45,6 +45,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Added required `array` argument when invoking `SerializationError` ([#419](https://github.com/opensearch-project/opensearch-js/pull/419)) | |||
| - Removed unnecessary `data` argument when invoking `OpenSearchClientError` ([#421](https://github.com/opensearch-project/opensearch-js/pull/421)) | |||
| - Fixed typos in `ConnectionPool` ([#427](https://github.com/opensearch-project/opensearch-js/pull/427)) | |||
| - Added `BaseConnectionPool` `markDead` and `markAlive` methods implementation ([#430](https://github.com/opensearch-project/opensearch-js/pull/430)) | |||
There was a problem hiding this comment.
Try to write this from the user's perspective, before they tried to call markDead and it didn't work. You're fixing it, so let's say "Fixed BaseConnectionPool#markDead and #markAlive"
Will do |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement BaseConnectionPool
markDeadandmarkAlivemethodsFix unit test
Issues Resolved
Closes #429
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.