Add k-NN guide and samples #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
reviewed
Jul 26, 2023
| - [Create a client using `ApacheHttpClient5Transport`](#create-a-client-using-apachehttpclient5transport) | ||
| - [Create a client using `RestClientTransport` (deprecated)](#create-a-client-using-restclienttransport-deprecated) |
reta
reviewed
Jul 26, 2023
| mainClass.set("org.opensearch.client.samples.Main") | ||
| } | ||
|
|
||
| tasks.named<JavaExec>("run") { |
There was a problem hiding this comment.
Probably not needed :-) Shouldn't the property be picked up if defined?
reta
reviewed
Jul 26, 2023
|
|
||
| package org.opensearch.client.samples; | ||
|
|
||
| public class RandUtil { |
There was a problem hiding this comment.
Probably knn package is better place, I suspect we would have more samples added
reta
approved these changes
Jul 26, 2023
VachaShah
pushed a commit
to VachaShah/opensearch-java
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com>
reta
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Add k-NN guide and samples (#586) Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> * Reorganizing user guide and adding working samples (#610) * Reorganizing user guide and moving code snippets to guides Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding working samples for the client Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing compile errors for ApacheHttpClient5Transport Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documents how to perform approximate k-NN searches and adds complete running samples for the different k-NN queries.
Based off @dblock's work in opensearch-project/opensearch-py#449
Issues Resolved
Resolves #578
Resolves #558
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.