Adds point in time APIs #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavamsi
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
harshavamsi
force-pushed
the
feature/pointintime
branch
3 times, most recently
from
206cd63
to
d7e6d3b
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
feature/pointintime
branch
from
d7e6d3b
to
cb6d15f
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
dblock
reviewed
Apr 25, 2023
java-client/src/main/java/org/opensearch/client/opensearch/core/SearchRequest.java
Show resolved
Hide resolved
VachaShah
reviewed
Apr 25, 2023
.../main/java/org/opensearch/client/opensearch/core/point_in_time/CreatePointInTimeRequest.java
Outdated
Show resolved
Hide resolved
reta
reviewed
May 1, 2023
java-client/src/main/java/org/opensearch/client/opensearch/OpenSearchAsyncClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
|
@VachaShah @dblock @reta this should be good to go I believe? |
Thanks for addressing comments @harshavamsi , the class names are still using [1] https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/action/search/CreatePitRequest.java |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
reta
reviewed
May 2, 2023
reta
reviewed
May 2, 2023
Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
reta
reviewed
May 2, 2023
java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractCatClientIT.java
Outdated
Show resolved
Hide resolved
reta
reviewed
May 2, 2023
java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractRequestIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
reta
approved these changes
May 2, 2023
dblock
approved these changes
May 3, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-461-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4ceb43b00c314b6acba6d036132d1947d22b5f8d
# Push it to GitHub
git push --set-upstream origin backport/backport-461-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
|
@harshavamsi will need a manual backport |
harshavamsi
added a commit
to harshavamsi/opensearch-java
that referenced
this pull request
May 4, 2023
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 4ceb43b)
harshavamsi
added a commit
to harshavamsi/opensearch-java
that referenced
this pull request
May 4, 2023
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 4ceb43b)
harshavamsi
added a commit
to harshavamsi/opensearch-java
that referenced
this pull request
May 8, 2023
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 4ceb43b)
reta
pushed a commit
that referenced
this pull request
May 9, 2023
* Adds point in time APIs Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add version check for Point in time tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time namespace Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update point in time to pit everywhere Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update USER_GUIDE.md Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using AssumeTrue for tests for PIT Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 4ceb43b)
|
Just a question, when the next tag that contain this feature will be released ? |
Hi @ahmadabulaban, we are tracking the release 2.5.0 in #474. Till we release 2.5.0, you can use the snapshots we publish for the client - 2.5.0-SNAPSHOT which has the latest changes from the 2.x branch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds point in time APIs that were released in OpenSearch 2.4
Issues Resolved
Closes #452
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.