Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue when tracktotalhits is disabled #372

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

VachaShah
Copy link
Collaborator

Description

When trackTotalHits is disabled, the search request fails. Fixing in this PR.

Issues Resolved

Closes #354

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah
Copy link
Collaborator Author

Failing Integration with Unreleased OpenSearch fixed in #375

reta
reta previously approved these changes Feb 21, 2023
dblock
dblock previously approved these changes Feb 28, 2023
CHANGELOG.md Outdated
@@ -34,7 +34,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Update Gradle to 7.6 ([#309](https://github.com/opensearch-project/opensearch-java/pull/309))
- Prevent SPI calls at runtime ([#293](https://github.com/opensearch-project/opensearch-java/pull/293))
- Add support for OpenSearch Serverless ([#339](https://github.com/opensearch-project/opensearch-java/pull/339))
- Fix issue where completion suggestions were failing, due to being parsed as term suggestions ([#107](https://github.com/opensearch-project/opensearch-java/issues/107))
- Fix issue where completion suggestions were failing, due to being parsed as term suggestions ([#347](https://github.com/opensearch-project/opensearch-java/pull/347))
- Fix issue when trackTotalHits is disabled ([#372](https://github.com/opensearch-project/opensearch-java/pull/372))
Copy link
Member

@dblock dblock Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next time/another PR, I think we should write a better description. For this one it would say "Fix request failing with X when trackTotalHits is disabled".

Updated the changelog entry in rebasing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@dblock dblock dismissed stale reviews from reta and themself via b3ee1e1 February 28, 2023 19:11
@dblock dblock requested a review from reta February 28, 2023 19:12
@reta reta merged commit 7b9f8c7 into opensearch-project:main Mar 3, 2023
@reta reta added the backport 2.x Backport to 2.x branch label Mar 3, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-372-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7b9f8c735facacc31c4caae6592496c207a58ed4
# Push it to GitHub
git push --set-upstream origin backport/backport-372-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-372-to-2.x.

MarinaRazumovsky pushed a commit to MarinaRazumovsky/opensearch-java that referenced this pull request Mar 19, 2023
* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Update Changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>
MarinaRazumovsky pushed a commit to MarinaRazumovsky/opensearch-java that referenced this pull request Mar 19, 2023
* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Update Changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>
MarinaRazumovsky pushed a commit to MarinaRazumovsky/opensearch-java that referenced this pull request Mar 20, 2023
* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Update Changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>
dblock added a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding documentation comment

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Updating the developer guide

Signed-off-by: Vacha Shah <vachshah@amazon.com>

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <git@danielhart.me>

* Remove commented code

Signed-off-by: Dan Hart <git@danielhart.me>

* Fix format of changelog item

Signed-off-by: Dan Hart <git@danielhart.me>

Signed-off-by: Dan Hart <git@danielhart.me>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bumps Jackson from 2.14.1 to 2.14.2 (#357)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Fix formatting

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <123amitai@gmail.com>

* latest 2.4 version

Signed-off-by: amitai stern <123amitai@gmail.com>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <123amitai@gmail.com>

---------

Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

* fix: add a missing key propery to the RangeBucket (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

* docs: add CHANGELOG entry (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

---------

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fixing integration tests (#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Adding bulk request example in user guide (#373)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Update Changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* changes changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add 2PR approval to release workflow (#383)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Adding an example to use raw JSON class instead of target classes (#385)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Update Gradle to 8.0.2 (#392)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add "mappings" field to IndexSettings object (#382)

Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Created untriaged issue workflow. (#364)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add buffered lookahead for Jackson (#338)

Signed-off-by: luneo7 <luneo7@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Mask env values for snapshots (#411)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* fix test

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* fix changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>
Signed-off-by: Dan Hart <git@danielhart.me>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: luneo7 <luneo7@gmail.com>
Co-authored-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Danny Hart <git@danielhart.me>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: amitai stern <123amitai@gmail.com>
Co-authored-by: szczepanczykd <48957041+szczepanczykd@users.noreply.github.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: Ilya Lukyanovich <ilya.lukyanovich@dataart.com>
Co-authored-by: Lucas Rogerio Caetano Ferreira <luneo7@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding documentation comment

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Updating the developer guide

Signed-off-by: Vacha Shah <vachshah@amazon.com>

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <git@danielhart.me>

* Remove commented code

Signed-off-by: Dan Hart <git@danielhart.me>

* Fix format of changelog item

Signed-off-by: Dan Hart <git@danielhart.me>

Signed-off-by: Dan Hart <git@danielhart.me>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bumps Jackson from 2.14.1 to 2.14.2 (#357)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Fix formatting

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <123amitai@gmail.com>

* latest 2.4 version

Signed-off-by: amitai stern <123amitai@gmail.com>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <123amitai@gmail.com>

---------

Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

* fix: add a missing key propery to the RangeBucket (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

* docs: add CHANGELOG entry (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

---------

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fixing integration tests (#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Adding bulk request example in user guide (#373)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Update Changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* changes changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add 2PR approval to release workflow (#383)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Adding an example to use raw JSON class instead of target classes (#385)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Update Gradle to 8.0.2 (#392)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add "mappings" field to IndexSettings object (#382)

Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Created untriaged issue workflow. (#364)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add buffered lookahead for Jackson (#338)

Signed-off-by: luneo7 <luneo7@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Mask env values for snapshots (#411)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* fix test

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* fix changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>
Signed-off-by: Dan Hart <git@danielhart.me>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: luneo7 <luneo7@gmail.com>
Co-authored-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Danny Hart <git@danielhart.me>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: amitai stern <123amitai@gmail.com>
Co-authored-by: szczepanczykd <48957041+szczepanczykd@users.noreply.github.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: Ilya Lukyanovich <ilya.lukyanovich@dataart.com>
Co-authored-by: Lucas Rogerio Caetano Ferreira <luneo7@users.noreply.github.com>
(cherry picked from commit 938170a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta added a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding documentation comment

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Updating the developer guide

Signed-off-by: Vacha Shah <vachshah@amazon.com>

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <git@danielhart.me>

* Remove commented code

Signed-off-by: Dan Hart <git@danielhart.me>

* Fix format of changelog item

Signed-off-by: Dan Hart <git@danielhart.me>

Signed-off-by: Dan Hart <git@danielhart.me>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bumps Jackson from 2.14.1 to 2.14.2 (#357)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Fix formatting

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <123amitai@gmail.com>

* latest 2.4 version

Signed-off-by: amitai stern <123amitai@gmail.com>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <123amitai@gmail.com>

---------

Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

* fix: add a missing key propery to the RangeBucket (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

* docs: add CHANGELOG entry (#369)

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>

---------

Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fixing integration tests (#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Adding bulk request example in user guide (#373)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Update Changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* changes changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add 2PR approval to release workflow (#383)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Adding an example to use raw JSON class instead of target classes (#385)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Update Gradle to 8.0.2 (#392)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add "mappings" field to IndexSettings object (#382)

Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Created untriaged issue workflow. (#364)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Add buffered lookahead for Jackson (#338)

Signed-off-by: luneo7 <luneo7@gmail.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* Mask env values for snapshots (#411)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* fix test

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* fix changelog

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>
Signed-off-by: Dan Hart <git@danielhart.me>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: luneo7 <luneo7@gmail.com>
Co-authored-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Danny Hart <git@danielhart.me>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: amitai stern <123amitai@gmail.com>
Co-authored-by: szczepanczykd <48957041+szczepanczykd@users.noreply.github.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: Ilya Lukyanovich <ilya.lukyanovich@dataart.com>
Co-authored-by: Lucas Rogerio Caetano Ferreira <luneo7@users.noreply.github.com>
(cherry picked from commit 938170a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock added a commit that referenced this pull request Mar 21, 2023
* Adding x-amz-content-sha256 header for signed requests (#339)

* Adding X-Amz-Content-Sha256 header for signed requests



* Adding CHANGELOG entry



* Adding documentation comment



* Adding tests



* Addressing comments



* Addressing comments



* Removing refresh policy for integ tests for Sigv4



* Updating the developer guide






* Fix issue with completion suggester being parsed as term suggester. (#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida



* Remove commented code



* Fix format of changelog item






* Update USER_GUIDE to use exact AWS brand names (#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.






* Bumps Jackson from 2.14.1 to 2.14.2 (#357)




* Bulk UpdateOperation misses upsert options (#353)

* Bulk UpdateOperation misses upsert options



* Fix formatting



---------




* Upgrading compatibility to opensearch 2.5 (#367)

* Upgrading compatibility to opensearch 2.5



* latest 2.4 version



* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0



---------




* add option to set columns into cat indices request



* add changelog



* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests



* Feature/range aggregation fix 369 (#370)

* test: create integration tests for date_range and range aggregation (#369)



* fix: add a missing key propery to the RangeBucket (#369)



* docs: add CHANGELOG entry (#369)



---------




* Fixing integration tests (#375)

* Fixing integration tests



* Updating the test with a non-exact check



---------




* Adding bulk request example in user guide (#373)




* Fixing issue when tracktotalhits is disabled (#372)

* Fixing issue when tracktotalhits is disabled



* Update Changelog



---------





* changes changelog



* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...



* Update changelog



---------






* Add 2PR approval to release workflow (#383)




* Adding an example to use raw JSON class instead of target classes (#385)




* Update Gradle to 8.0.2 (#392)




* Add "mappings" field to IndexSettings object (#382)




* Created untriaged issue workflow. (#364)




* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...



* Update changelog



---------






* Add buffered lookahead for Jackson (#338)




* Mask env values for snapshots (#411)




* option to set headers and sort into cat requests



* fix test



* fix changelog



* add cat examples into USER_GUID



---------

























(cherry picked from commit 938170a)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: MarinaRazumovsky <rzm.mrn@gmail.com>
Signed-off-by: Dan Hart <git@danielhart.me>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: amitai stern <123amitai@gmail.com>
Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Ilya Lukyanovich <l000kian@gmail.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: luneo7 <luneo7@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Danny Hart <git@danielhart.me>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: amitai stern <123amitai@gmail.com>
Co-authored-by: szczepanczykd <48957041+szczepanczykd@users.noreply.github.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: Ilya Lukyanovich <ilya.lukyanovich@dataart.com>
Co-authored-by: Lucas Rogerio Caetano Ferreira <luneo7@users.noreply.github.com>
@VachaShah VachaShah deleted the issue-354 branch April 12, 2023 19:26
VachaShah added a commit to VachaShah/opensearch-java that referenced this pull request Apr 13, 2023
* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Update Changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
VachaShah added a commit that referenced this pull request Apr 13, 2023
* Fixing issue when tracktotalhits is disabled



* Update Changelog



---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HitsMetadata total hits is mandatory, but shouldn't be.
3 participants