Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FilterPath param #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaximMolchanov
Copy link
Contributor

Description

Added filter path param

Issues Resolved

Closes #616

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0.66225% with 450 lines in your changes missing coverage. Please review.

Project coverage is 60.24%. Comparing base (06a6dc8) to head (bf2f215).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
opensearchapi/api_indices-alias-params.go 0.00% 8 Missing and 4 partials ⚠️
opensearchapi/api_cluster-decommission-params.go 0.00% 6 Missing and 3 partials ⚠️
opensearchapi/api_cluster-settings-params.go 0.00% 4 Missing and 2 partials ⚠️
...api/api_cluster-voting_config_exclusions-params.go 0.00% 6 Missing ⚠️
opensearchapi/api_indices-mapping-params.go 0.00% 4 Missing and 2 partials ⚠️
opensearchapi/api_indices-settings-params.go 0.00% 4 Missing and 2 partials ⚠️
opensearchapi/api_aliases-params.go 0.00% 2 Missing and 1 partial ⚠️
opensearchapi/api_bulk-params.go 0.00% 2 Missing and 1 partial ⚠️
opensearchapi/api_cat-aliases-params.go 0.00% 2 Missing and 1 partial ⚠️
opensearchapi/api_cat-allocation-params.go 0.00% 2 Missing and 1 partial ⚠️
... and 131 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   57.29%   60.24%   +2.95%     
==========================================
  Files         315      376      +61     
  Lines        9823    11586    +1763     
==========================================
+ Hits         5628     6980    +1352     
- Misses       2902     3179     +277     
- Partials     1293     1427     +134     
Flag Coverage Δ
integration 52.70% <0.00%> (+1.86%) ⬆️
unit 14.83% <0.66%> (+1.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
opensearchapi/api_search-params.go 90.38% <100.00%> (+83.05%) ⬆️
opensearchapi/api_aliases-params.go 16.00% <0.00%> (-2.19%) ⬇️
opensearchapi/api_bulk-params.go 35.29% <0.00%> (-2.21%) ⬇️
opensearchapi/api_cat-aliases-params.go 18.18% <0.00%> (-1.82%) ⬇️
opensearchapi/api_cat-allocation-params.go 14.28% <0.00%> (-1.10%) ⬇️
opensearchapi/api_cat-cluster_manager-params.go 16.66% <0.00%> (-1.52%) ⬇️
opensearchapi/api_cat-count-params.go 22.22% <0.00%> (-2.78%) ⬇️
opensearchapi/api_cat-fielddata-params.go 20.00% <0.00%> (-2.23%) ⬇️
opensearchapi/api_cat-health-params.go 18.18% <0.00%> (-1.82%) ⬇️
opensearchapi/api_cat-indices-params.go 16.66% <0.00%> (-0.99%) ⬇️
... and 132 more

... and 74 files with indirect coverage changes

@dblock
Copy link
Member

dblock commented Feb 21, 2025

Thanks @MaximMolchanov, amend your PR with -s for DCO and add to CHANGELOG please.

This kind of change really shows that we need #284, maybe you want to help?

Signed-off-by: Maxim Molchanov <maksym.n.molchanov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support for filter_path query parameter
2 participants