Feature: Idiomatic lib

.github/license-header.txt

@@ -3,6 +3,3 @@
 // The OpenSearch Contributors require contributions made to
 // this file be licensed under the Apache-2.0 license or a
 // compatible open source license.
-//
-// Modifications Copyright OpenSearch Contributors. See
-// GitHub history for details.

.github/workflows/test-integration-unreleased.yml

@@ -66,6 +66,8 @@ jobs:
       - name: Integration test
         working-directory: go-client
         run: make test-integ race=true
+        env:
+          OPENSEARCH_GO_SKIP_JSON_COMPARE: true
 
       - name: Save server logs
         if: failure()

.golangci.yml

@@ -1,7 +1,6 @@
 run:
   timeout: 10m
   modules-download-mode: readonly
-  issues-exit-code: 0
 
 linters-settings:
   errcheck:
@@ -37,11 +36,21 @@ linters-settings:
     check-exported: true
   misspell:
     locale: US
-    ignore-words: expect
+    ignore-words:
+      - expect
+      - cancelled
   prealloc:
     simple: true
     range-loops: true
     for-loops: false
+  revive:
+    rules:
+      - name: exported
+        severity: error
+        disabled: false
+        arguments:
+          - "checkPrivateReceivers"
+          - "sayRepetitiveInsteadOfStutters"
 
 linters:
   disable-all: true
@@ -76,7 +85,6 @@ linters:
     - gofumpt
     - goheader
     - goimports
-    - gomnd
     - gomoddirectives
     - gomodguard
     - goprintffuncname
@@ -124,16 +132,18 @@ linters:
     - zerologlint
 
 issues:
+  include:
+    - EXC0012
+    - EXC0014
   exclude-rules:
-    - path: _test\.go
+    - path: (_test\.go|opensearchapi/internal)
       linters:
         - cyclop
         - dupl
         - errcheck
         - gochecknoglobals
         - gochecknoinits
         - goconst
-        - gomnd
         - noctx
     - linters:
         - gosec
@@ -149,16 +159,17 @@ issues:
       path: _test\.go
     - linters:
         - goconst
-      text: "string `true` has"
       path: opensearchapi\/api_
     - linters:
         - errcheck
       text: "Error return value of `debugLogger.Logf` is not checked"
     - linters:
         - errcheck
-        - gomnd
         - gochecknoglobals
       path: opensearchtransport\/logger\.go
     - linters:
         - nestif
       path: opensearchtransport/opensearchtransport.go
+    - linters:
+        - dupl
+      path: (-params\.go|api_indices|api_dangling\.go|api_point_in_time\.go|rethrottle\.go|api_cat-.*\.go)

CHANGELOG.md

@@ -18,6 +18,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Adds `Err()` function to Response for detailed errors ([#246](https://github.com/opensearch-project/opensearch-go/pull/246))
 - Adds golangci-lint as code analysis tool ([#313](https://github.com/opensearch-project/opensearch-go/pull/313))
 - Adds govulncheck to check for go vulnerablities ([#405](https://github.com/opensearch-project/opensearch-go/pull/405))
+- Adds opensearchapi with new client and function structure ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
+- Adds integration tests for all opensearchapi functions ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
 
 ### Changed
 
@@ -27,18 +29,25 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Updated Developer guide to include docker build instructions ([#385](https://github.com/opensearch-project/opensearch-go/pull/385))
 - Test against version 2.9.0,2.10.0, run tests in all branches, change intergration tests to wait for OpenSearch to start ([#392](https://github.com/opensearch-project/opensearch-go/pull/392))
 - Makefile: use docker golangci-lint, run integration test on `.` folder, change coverage generation ([#392](https://github.com/opensearch-project/opensearch-go/pull/392)) 
+- golangci-lint: update rules and fail when issues are found ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
+- go: update to golang version 1.20 ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
+- guids: updated to work for the new opensearchapi ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
+- Test adjusted to new opensearchapi functions and structs ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
 
 ### Deprecated
 
 - Deprecate legacy API /_template ([#390](https://github.com/opensearch-project/opensearch-go/pull/390))
 
 ### Removed
 
+- Removes all old opensearchapi functions ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
+- Removes /internal/build code and folders ([#421](https://github.com/opensearch-project/opensearch-go/pull/421))
+
 ### Fixed
 
 - Corrects AWSv4 signature on DataStream Stats with no index name specified ([#338](https://github.com/opensearch-project/opensearch-go/pull/338))
 - Fixed GetSourceRequest `Source` field and deprecated the `Source` parameter ([#402](https://github.com/opensearch-project/opensearch-go/pull/402))
 
 ### Security
 
-[Unreleased]: https://github.com/opensearch-project/opensearch-go/compare/v2.3.0...HEAD
+[Unreleased]: https://github.com/opensearch-project/opensearch-go/compare/v2.3.0...HEAD

DEVELOPER_GUIDE.md

@@ -29,13 +29,13 @@ Fork [opensearch-project/opensearch-go](https://github.com/opensearch-project/op
 
 ### Install Prerequisites
 
-#### Go 1.15
+#### Go 1.20
 
-OpenSearch Go Client builds using [Go](https://golang.org/doc/install) 1.15 at a minimum.
+OpenSearch Go Client builds using [Go](https://go.dev/doc/install) 1.20 at a minimum.
 
 #### Docker
 
-[Docker](https://docs.docker.com/install/) is required for building some OpenSearch artifacts and executing integration tests.
+[Docker](https://docs.docker.com/get-docker/) is required for building some OpenSearch artifacts and executing integration tests.
 
 #### Windows
 

Makefile

@@ -72,12 +72,6 @@ lint:  ## Run lint on the package
 	@printf "\033[2m→ Running lint...\033[0m\n"
 	go vet github.com/opensearch-project/opensearch-go/...
 	go list github.com/opensearch-project/opensearch-go/... | 'grep' -v internal | xargs golint -set_exit_status
-	@{ \
-		set -e ; \
-		trap "test -d ../../../.git && git checkout --quiet go.mod" INT TERM EXIT; \
-		echo "cd internal/build/ && go vet ./..."; \
-		cd "internal/build/" && go mod tidy && go mod download && go vet ./...; \
-	}
 
 package := "prettier"
 lint.markdown:
@@ -218,7 +212,7 @@ cluster.clean: ## Remove unused Docker volumes and networks
 	docker system prune --volumes --force
 
 linters:
-	docker run -t --rm -v $$(pwd):/app -v ~/.cache/golangci-lint/v1.53.3:/root/.cache -w /app golangci/golangci-lint:v1.53.3 golangci-lint run --timeout=5m
+	docker run -t --rm -v $$(pwd):/app -v ~/.cache/golangci-lint/v1.54.2:/root/.cache -w /app golangci/golangci-lint:v1.54.2 golangci-lint run --timeout=5m
 
 workflow: ## Run all github workflow commands here sequentially