Add operations with data streams #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
dblock
reviewed
Mar 21, 2023
| // Modifications Copyright OpenSearch Contributors. See | ||
| // GitHub history for details. | ||
|
|
||
| // Licensed to Elasticsearch B.V. under one or more contributor |
There was a problem hiding this comment.
You don't need an ES license grant for new code, remove.
| // ----- API Definition ------------------------------------------------------- | ||
|
|
||
| // IndicesCreateDataStream creates a data stream. | ||
| // |
There was a problem hiding this comment.
Remove these many empty commented lines?
| path.WriteString("/") | ||
| path.WriteString("_data_stream") | ||
| path.WriteString("/") | ||
| path.WriteString(r.Name) |
There was a problem hiding this comment.
This path is hard-coded except for r.Name, can we collapse into 2 WriteString?
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
requested review from
dblock
and removed request for
VachaShah and
VijayanB
|
Looks like some failures in tests, but otherwise looks good! |
|
@dblock yes, my bad, did not look at the instructions on the Makefile. It seems that I wrote not unit tests, so thinking about adding integration tags, since I need an opensearch instance for the test. What do you think? |
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
dblock
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented Data Stream API:
Planned to add:
Issues Resolved
Closes [#152]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.