-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AD cypress tests for uncovered workflows and pages #95
Conversation
@amitgalitz @ylwu @kaituo this adds a lot of test cases for AD Dashboards - if some of you have time to take a look that would be helpful. Details in the PR description |
Tests failing until related AD PR is merged first: opensearch-project/anomaly-detection-dashboards-plugin#183 |
Can we get some reviewers to approve your related PR? @ohltyler |
I'm trying :) |
AD PR merged, re-running tests now @tianleh |
@tianleh @Tengda-He the CI workflow is using 1.2.0 bundle so these tests will fail, since it's dependent on AD plugin changes specific to 1.3.0. Lmk how you want to proceed. I think we can either start versioning and bump to pull in a 1.3.0 candidate tarball, or consider the failures acceptable until |
cc @seraphjiang for visibility |
We have upgraded the main branch to 1.3.0 #104 There are some known failures where we are working with owners to fix them. #104 (comment) By syncing the latest main branch into your PR, you will be able to see your test results against latest 1.3.0 and address any failures related to your change in this PR. |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Rebased with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks like that this issue to have coverage report is more needed as more plugins are on this repo. #88
Description
This PR adds a significant amount of tests for the Anomaly Detection Dashboards plugin. Main changes include:
getElementByTestId()
, and AD-specific helpersdata-test-subj
tags, instead of internal EUI tagsRelated PR which adds the test IDs used in these tests: link
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.