Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer waitForLoader before checking for icon #857

Merged
merged 1 commit into from
Sep 15, 2023

Commits on Sep 14, 2023

  1. Buffer waitForLoader before checking for icon

    Some async calls occur after navigating and sometimes navigating too quickly
    prevents the calls from having correct data and therefore the homeIcon is in
    a bad state.
    
    This adds the ability to buffer before checking for the homeIcon.
    
    Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures
    WAIT_FOR_LOADER_BUFFER_MS to be 500 ms
    
    Issue resolved:
    opensearch-project/OpenSearch-Dashboards#5028
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    559ae53 View commit details
    Browse the repository at this point in the history