Adding test for opensearch_security.multitenancy.enabled disabled #653
Conversation
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
abhivka7
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc and
peterzhuamazon
as code owners
| @@ -0,0 +1,25 @@ | |||
| /* | |||
There was a problem hiding this comment.
@abhivka7 Where is the setup for this test? Is it set to multi-tenancy disabled by default?
There was a problem hiding this comment.
That will be done through workflow in Security Dashboards plugin. Here is the commit: opensearch-project/security-dashboards-plugin@b70c248
PR: https://github.com/opensearch-project/security-dashboards-plugin/pull/1419/commits
There was a problem hiding this comment.
Do you think you should add a part of the test where the feature is also enabled? Is it possible to show the feature going from enabled to disabled or vice versa? I am not familiar very familiar with these test setups so I don't know whether it can persist a state across the config change or not.
@scrawfor99 The tests added here: #609 take care of case where the feature is enabled. Switching tenant didn't work as it would require a node startup. |
|
Need backports? |
@peterzhuamazon I am not sure. These tests for now should run for 2.7 |
Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> (cherry picked from commit e601884)
Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> (cherry picked from commit e601884)
…ensearch-project#653) (opensearch-project#655) Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> (cherry picked from commit e601884) Co-authored-by: Abhi Kalra <99718513+abhivka7@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Description
We are adding a new cypress test to check if Dashboards tenancy features are disabled when
opensearch_security.multitenancy.enabledis disabled in theopensearchdashboard.yamlfile.Issues Resolved
Cypress tests for PR: opensearch-project/security-dashboards-plugin#1419
Check List
Testing video:
unaccessible_tenancy_feature.js.mp4
Testing by running cypress test from Security-Dashboards plugin;
https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/4894295743/jobs/8738346716
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.