Adds linter rules for license and import. Fixes lint issues #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-pc
commented
Oct 6, 2022
Comment on lines
69
to
71
| // cy.log('Deleting index with name: ' + indexName); | ||
| // cy.deleteIndex(indexName); |
There was a problem hiding this comment.
This should not break any test since indexName is actually not defined anywhere. I'm not sure how the tests were running for this to begin with.
There was a problem hiding this comment.
hey @ohltyler , do you have context for this test? it's weird that indexName is not defined
kavilla
approved these changes
Oct 6, 2022
Great idea! Seems another good first issue. |
tianleh
approved these changes
Oct 6, 2022
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-319-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 317f15665b900737565eff8c8b0b8534f47ddac1
# Push it to GitHub
git push --set-upstream origin backport/backport-319-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
tianleh
pushed a commit
that referenced
this pull request
Oct 15, 2022
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> (cherry picked from commit 317f156)
1 task
tianleh
added a commit
that referenced
this pull request
Oct 15, 2022
jakubp-eliatra
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
…roject#319) Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashwin Pc ashwinpc@amazon.com
Description
Adds two eslint rules and fixes issues caught by the linter
Issues Resolved
Fixes linting issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.