-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds linter rules for license and import. Fixes lint issues #319
Conversation
// cy.log('Deleting index with name: ' + indexName); | ||
// cy.deleteIndex(indexName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not break any test since indexName
is actually not defined anywhere. I'm not sure how the tests were running for this to begin with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @ohltyler , do you have context for this test? it's weird that indexName is not defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! Did we want to add a lint github workflow?
Great idea! Seems another good first issue. |
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-319-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 317f15665b900737565eff8c8b0b8534f47ddac1
# Push it to GitHub
git push --set-upstream origin backport/backport-319-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> (cherry picked from commit 317f156)
…roject#319) Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
Signed-off-by: Ashwin Pc ashwinpc@amazon.com
Description
Adds two eslint rules and fixes issues caught by the linter
Issues Resolved
Fixes linting issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.