Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] update test for common delete modal #268

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jul 11, 2022

Description

Origin: opensearch-project/observability@9d16389

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Related

opensearch-project/opensearch-build#1818

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Origin: opensearch-project/observability@9d16389

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner July 11, 2022 05:41
Copy link
Contributor

@eugenesk24 eugenesk24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rocky!!

@kavilla kavilla merged commit f6fc9a0 into opensearch-project:main Jul 25, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2022
Origin: opensearch-project/observability@9d16389

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit f6fc9a0)
@kavilla kavilla deleted the avillk/2.1/obs_test branch July 25, 2022 20:26
Copy link
Member

@tianleh tianleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kavilla added a commit that referenced this pull request Jul 25, 2022
Origin: opensearch-project/observability@9d16389

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit f6fc9a0)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla added the v2.2.0 'Issues and PRs related to version v2.3.0' label Jul 25, 2022
CCongWang pushed a commit that referenced this pull request Feb 10, 2023
Origin: opensearch-project/observability@9d16389

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit f6fc9a0)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Cong Wang <conjwang@amazon.com>
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
…ct#268)

Origin: opensearch-project/observability@9d16389

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.2.0 'Issues and PRs related to version v2.3.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants