Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases and Github actions ported from Monterey project #2

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

tianleh
Copy link
Member

@tianleh tianleh commented Sep 24, 2021

Description

This change basically ports the test cases in Monterey project https://github.com/tianleh/monterey-test It looks lengthy since it is a bulk package level move. We want to review the following modifications made on top of the Monterey project.

  1. update the dependency of the test library to the official repository https://github.com/opensearch-project/opensearch-dashboards-test-library
  2. update other repository links
  3. update imports in test case files

Issues Resolved

#1

Check List

  • [ Cypress workflow for source code based] Commits are signed per the DCO using --signoff
  • [ Cypress workflow for snapshot artifact based] Commits are signed per the DCO using --signoff
  • [ Cypress workflow for bundled artifact based] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@seraphjiang seraphjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks tianle. Seems one of the workflows fails. Can you verify it?

@tianleh
Copy link
Member Author

tianleh commented Sep 24, 2021

thanks tianle. Seems one of the workflows fails. Can you verify it?

Thanks for the scrutiny! After rerunning the job, it is now all successful. Sometimes it takes longer than usual to download/bootstrap/run osd. We could potentially increase the timeout if it is more flaky.

@tianleh tianleh merged commit 564c182 into main Sep 24, 2021
@tianleh tianleh deleted the dev-port-monterey branch November 9, 2021 08:41
eugenesk24 pushed a commit to eugenesk24/opensearch-dashboards-functional-test that referenced this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants