-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Flow Framework Dashboards integration tests #1586
Conversation
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
@ohltyler, please take a look at this PR. -Running tests without security are passing in dashboards flow framework plugin workflow .
|
Signed-off-by: saimedhi <saimedhi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Few comments, but overall looks good.
cypress/fixtures/plugins/dashboards-flow-framework/search_response.json
Outdated
Show resolved
Hide resolved
cypress/integration/plugins/dashboards-flow-framework/create_workflow_spec.js
Outdated
Show resolved
Hide resolved
cypress/integration/plugins/dashboards-flow-framework/create_workflow_spec.js
Outdated
Show resolved
Hide resolved
cypress/integration/plugins/dashboards-flow-framework/create_workflow_spec.js
Outdated
Show resolved
Hide resolved
cypress/integration/plugins/dashboards-flow-framework/create_workflow_spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
|
Still seeing the ML commons failure is causing the failed check:
Please check with ML commons team if there is some issues with that plugin being available in the distribution used in the test. The error indicates the plugin is not present. |
@ohltyler, Latest build has following error stated below( https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/detail/distribution-build-opensearch/10410/pipeline).
CC: @minalsha |
Signed-off-by: saimedhi <saimedhi@amazon.com>
@peterzhuamazon, @prudhvigodithi , @ohltyler could you please take a look at this PR. The latest build used in this workflow also has build errors causing tests added in this PR fail. Let me know if this PR could be merged. |
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and the custom cluster setup in our repo is passing. I'm ok to merge, and lets make sure the 2.x backport actions are passing, as the 2.x distros should be more stable.
* Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Update dashboards-flow-framework-e2e-workflow.yml Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> * Update dashboards-flow-framework-e2e-workflow.yml Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fixes Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fixes Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fixes Signed-off-by: saimedhi <saimedhi@amazon.com> * Adding Flow Framework Dashboards integration tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Adding Flow Framework Dashboards integration tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fix flakiness Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> (cherry picked from commit 2f6c790)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1586-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2f6c79028183a9c4a187bec71b82c725d5bc24da
# Push it to GitHub
git push --set-upstream origin backport/backport-1586-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…t#1586) * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Update dashboards-flow-framework-e2e-workflow.yml Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> * Update dashboards-flow-framework-e2e-workflow.yml Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fixes Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fixes Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fixes Signed-off-by: saimedhi <saimedhi@amazon.com> * Adding Flow Framework Dashboards integration tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Adding Flow Framework Dashboards integration tests Signed-off-by: saimedhi <saimedhi@amazon.com> * Added Flow Framework Dashboards integ tests fix flakiness Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> (cherry picked from commit 2f6c790)
Description
Issues Resolved
related to opensearch-project/dashboards-flow-framework#22
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.