Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Flow Framework Dashboards integration tests #1586

Merged
merged 15 commits into from
Oct 18, 2024

Conversation

saimedhi
Copy link
Contributor

@saimedhi saimedhi commented Oct 14, 2024

Description

  • Adding Flow Framework Dashboards integration tests.
  • This PR includes testing for the below cases:
    1. Create workflow using import
    2. Create workflow using templates
    3. Delete workflow from the workflow list

Issues Resolved

related to opensearch-project/dashboards-flow-framework#22

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi and others added 5 commits October 14, 2024 16:33
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Copy link
Contributor Author

@ohltyler, please take a look at this PR.

-Running tests without security are passing in dashboards flow framework plugin workflow .

  • Here, Running tests with security and seeing below error:

Creating Workflows Using Various Methods -- create workflow using Hybrid Search template (failed)

Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Few comments, but overall looks good.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Copy link
Contributor Author

saimedhi commented Oct 16, 2024

  • Tested the specs locally. and tests are working fine. @ohltyler, please take a look.
Screenshot 2024-10-16 at 11 32 53 AM Screenshot 2024-10-16 at 11 33 21 AM Screenshot 2024-10-16 at 11 33 35 AM Screenshot 2024-10-16 at 11 33 43 AM Screenshot 2024-10-16 at 11 33 51 AM

@ohltyler
Copy link
Member

Still seeing the ML commons failure is causing the failed check:

"error": "no handler found for uri [/_plugins/_ml/connectors/_create] and method [POST]"

Please check with ML commons team if there is some issues with that plugin being available in the distribution used in the test. The error indicates the plugin is not present.

@saimedhi
Copy link
Contributor Author

saimedhi commented Oct 16, 2024

@ohltyler, Latest build has following error stated below( https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/detail/distribution-build-opensearch/10410/pipeline).

  • This build error is causing tests to fail. Tested locally and attached screenshots.
  • @prudhvigodithi, please take a look at this PR and let me know if this can be merged.
BUILD FAILED in 3s

2024-10-16 04:44:19 ERROR    ERROR: Command 'bash /var/jenkins/workspace/distribution-build-opensearch/scripts/default/opensearch/build.sh -v 3.0.0 -p linux -a x64 -s false -o builds' returned non-zero exit status 1.

2024-10-16 04:44:19 ERROR    Error building user-behavior-insights, retry with: ./build.sh manifests/3.0.0/opensearch-3.0.0.yml --component user-behavior-insights

2024-10-16 04:44:21 INFO     Created build manifest /var/jenkins/workspace/distribution-build-opensearch/tar/builds/opensearch/manifest.yml

2024-10-16 04:44:21 INFO     Removing /tmp/tmpt4ctwxz2

2024-10-16 04:44:23 ERROR    Failed plugins are ['ml-commons', 'opensearch-reports', 'performance-analyzer', 'opensearch-observability', 'k-NN', 'neural-search', 'geospatial', 'anomaly-detection', 'cross-cluster-replication', 'notifications-core', 'notifications', 'alerting', 'sql', 'security-analytics', 'index-management', 'flow-framework', 'opensearch-system-templates', 'skills', 'user-behavior-insights']

2024-10-16 04:44:23 INFO     Done.

CC: @minalsha

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Copy link
Contributor Author

saimedhi commented Oct 17, 2024

@peterzhuamazon, @prudhvigodithi , @ohltyler could you please take a look at this PR. The latest build used in this workflow also has build errors causing tests added in this PR fail. Let me know if this PR could be merged.
https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/detail/distribution-build-opensearch/10412/pipeline/

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the custom cluster setup in our repo is passing. I'm ok to merge, and lets make sure the 2.x backport actions are passing, as the 2.x distros should be more stable.

@SuZhou-Joe SuZhou-Joe merged commit 2f6c790 into opensearch-project:main Oct 18, 2024
41 of 42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Update dashboards-flow-framework-e2e-workflow.yml

Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>

* Update dashboards-flow-framework-e2e-workflow.yml

Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fixes

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fixes

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fixes

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Adding Flow Framework Dashboards integration tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Adding Flow Framework Dashboards integration tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fix flakiness

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
(cherry picked from commit 2f6c790)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1586-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2f6c79028183a9c4a187bec71b82c725d5bc24da
# Push it to GitHub
git push --set-upstream origin backport/backport-1586-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1586-to-2.x.

saimedhi added a commit to saimedhi/opensearch-dashboards-functional-test that referenced this pull request Oct 18, 2024
…t#1586)

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Update dashboards-flow-framework-e2e-workflow.yml

Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>

* Update dashboards-flow-framework-e2e-workflow.yml

Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fixes

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fixes

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fixes

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Adding Flow Framework Dashboards integration tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Adding Flow Framework Dashboards integration tests

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Added Flow Framework Dashboards integ tests fix flakiness

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
(cherry picked from commit 2f6c790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants