Onboard alerting dashboards plugin #103
Conversation
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
Will add the rest once the modification is done Signed-off-by: Annie Lee <leeyun@amazon.com>
|
I am upgrading the main branch to support 1.3.0 in parallel #104 The Github workflows will be updated to use 1.3.0 artifacts once my pr is merged. |
Sounds good. The only test that is failing is a managed service specific test. So currently that failure is expected. |
|
We have upgraded the main branch to 1.3.0 #104 There are some known failures where we are working with owners to fix them. #104 (comment) By syncing the latest main branch into your PR, you will be able to see your test results against latest 1.3.0 and address any failures related to your change in this PR. |
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
| @@ -14,7 +14,8 @@ | |||
| "SECURITY_ENABLED": false, | |||
| "username": "admin", | |||
| "password": "admin", | |||
| "ENDPOINT_WITH_PROXY": false | |||
| "ENDPOINT_WITH_PROXY": false, | |||
There was a problem hiding this comment.
what is the difference between ENDPOINT_WITH_PROXY and MANAGED_SERVICE_ENDPOINT ?
There was a problem hiding this comment.
I think for the MANAGED_SERVICE_ENDPOINT flag we are trying to separate the tests that are only applicable to managed service side domain. In this case the Amazon SNS type destination is only on AWS Opensearch so it will fail on an open source domain. I believe there are cases when the domain is on managed service side and is not proxy enabled, so it could be 2 different flags.
I will add the description of this flag to the documentation too.
|
|
||
| export const ALERTING_PLUGIN_NAME = 'alerting'; | ||
|
|
||
| export const ADMIN_AUTH = { |
There was a problem hiding this comment.
can we use the common ADMIN_AUTH constant instead ?
There was a problem hiding this comment.
Yeah I can do that. Thanks for checking this.
|
Noticed a new error about alerting https://github.com/opensearch-project/opensearch-dashboards-functional-test/runs/5427093973?check_suite_focus=true |
|
The main branch has fixed all the failures. You can perform the rebase. |
|
Seeing a alerting test failure. Might be related to a fix from this PR. Checking into it. Seems like the cypress videos are not capturing the test runs. |
…ain flag Signed-off-by: Annie Lee <leeyun@amazon.com>
Description
Moving most util and constant files over. There are still a few spec test files pending refactor. Also adding the SNS alerting test (might fail with open source domain).
The remaining spec files to be ported are still working in progress on this branch:
https://github.com/leeyun-amzn/opensearch-dashboards-functional-test/tree/alerting-tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.