Update create table url and address style render (#692)

* Update create table url Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Add cy.wait Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Skip split test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit cf25a9a)
opensearch-project · May 30, 2023 · 2cdd23b · 2cdd23b
1 parent 37c79cd
commit 2cdd23b
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/...gration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_type_table/data.spec.js b/...gration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_type_table/data.spec.js
@@ -19,6 +19,9 @@ import {
 
 const commonUI = new CommonUI(cy);
 
+// TODO: Remove cy.wait(500)
+// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/4157
+
 describe('table visualization data', () => {
   before(() => {
     cy.deleteIndex(TABLE_INDEX_ID);
@@ -67,6 +70,7 @@ describe('table visualization data', () => {
         2
       );
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectedData);
       });
@@ -79,6 +83,7 @@ describe('table visualization data', () => {
       cy.tbSelectAggregationField('age', 3);
       cy.tbUpdateAggregationSettings();
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectedAverageData);
       });
@@ -102,6 +107,7 @@ describe('table visualization data', () => {
       cy.tbSelectSubAggregationType('Count', 2, 'metrics');
       cy.tbUpdateAggregationSettings();
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectedData);
       });
@@ -122,6 +128,7 @@ describe('table visualization data', () => {
       cy.tbSplitRows();
       cy.tbSetupDateHistogramAggregation('timestamp', 'Year', 2);
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectedData);
       });
@@ -130,6 +137,7 @@ describe('table visualization data', () => {
     it('Should correctly filter for applied time filter on the main timefield', () => {
       commonUI.addFilterRetrySelection('timestamp', 'is', '2022-05-30');
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(['2022', '37']);
       });
@@ -140,6 +148,7 @@ describe('table visualization data', () => {
         '2022-08-30',
       ]);
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(['2022', '3,370']);
       });
@@ -148,11 +157,13 @@ describe('table visualization data', () => {
     it('Should correctly filter for pinned filters', () => {
       commonUI.pinFilter('timestamp');
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(['2022', '3,370']);
       });
       commonUI.removeFilter('timestamp');
       cy.waitForLoader();
+      cy.wait(500);
     });
 
     after(() => {
@@ -166,6 +177,7 @@ describe('table visualization data', () => {
   describe('Check Terms aggregation and missing values', () => {
     it('Should show correct data before and after adding doc', () => {
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(['10,000']);
       });
@@ -210,12 +222,14 @@ describe('table visualization data', () => {
       cy.tbSplitRows();
       cy.tbSetupTermsAggregation('age', 'Descending', '5', 2);
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectDataBeforeGroupInOther);
       });
       cy.tbToggleOtherBucket('true');
       cy.tbUpdateAggregationSettings();
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectDataAfterGroupInOther);
       });
@@ -251,12 +265,14 @@ describe('table visualization data', () => {
       cy.tbSelectAggregationField('email.keyword', 2);
       cy.tbUpdateAggregationSettings();
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectDataBeforeMissing);
       });
       cy.tbToggleMissingBucket('true');
       cy.tbUpdateAggregationSettings();
       cy.waitForLoader();
+      cy.wait(500);
       cy.tbGetTableDataFromVisualization().then((data) => {
         expect(data).to.deep.eq(expectDataAfterMissing);
       });

diff --git a/...ration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_type_table/split.spec.js b/...ration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_type_table/split.spec.js
@@ -16,7 +16,8 @@ import {
   toTestId,
 } from '../../../../../utils/constants';
 
-describe('Split table', () => {
+// TODO: https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/699
+describe.skip('Split table', () => {
   const expectDataInitial = [
     [
       'Cat',

diff --git a/cypress/utils/dashboards/vis_type_table/constants.js b/cypress/utils/dashboards/vis_type_table/constants.js
@@ -20,7 +20,7 @@ export const TABLE_INDEX_END_TIME = 'Oct 2, 2022 @ 00:00:00.000';
 export const TABLE_BASIC_VIS_TITLE = 'TABLE: Basic';
 // App URL Paths
 export const TABLE_VIS_APP_PATH = '/app/visualize';
-export const TABLE_CREATE_URL = `${BASE_PATH}${TABLE_VIS_APP_PATH}/create?type=table&indexPattern=${TABLE_INDEX_PATTERN}`;
+export const TABLE_CREATE_URL = `${BASE_PATH}${TABLE_VIS_APP_PATH}#/create?type=table&indexPattern=${TABLE_INDEX_PATTERN}`;
 // Type
 export const TABLE_VIS_TYPE = 'visualization';
 // Aggregation

diff --git a/cypress/utils/dashboards/vis_type_table/table.js b/cypress/utils/dashboards/vis_type_table/table.js
@@ -93,7 +93,7 @@ Cypress.Commands.add(
         : action == 'filter out'
         ? filterOut
         : expand;
-    if (embed == true) {
+    if (embed) {
       cy.get('[data-test-subj="dataGridRowCell"]')
         .eq(rowIndex * totalColumn + colIndex)
         .click()