Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove io/ioutil dependency #86

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ginglis13
Copy link
Contributor

@ginglis13 ginglis13 commented Oct 13, 2023

Description

io/ioutil has been deprecated since Go 1.16
https://pkg.go.dev/io/ioutil

adding hacktoberfest label would be much appreciated :)

Issues Resolved

n/a

Check List

  • [n/a] New functionality includes testing.
    • All tests pass
  • [n/a] New functionality has been documented.
    • [n/a] New functionality has documentation added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

io/ioutil has been deprecated since Go 1.16
https://pkg.go.dev/io/ioutil

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #86 (054d7ac) into main (c53ff19) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   64.60%   64.60%           
=======================================
  Files          32       32           
  Lines        2328     2328           
=======================================
  Hits         1504     1504           
  Misses        716      716           
  Partials      108      108           
Flag Coverage Δ
opensearch-cli 64.60% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller/config/config.go 67.85% <100.00%> (ø)
handler/ad/ad.go 87.73% <100.00%> (ø)
mapper/platform/platform.go 97.16% <100.00%> (ø)
gateway/gateway.go 34.93% <50.00%> (ø)

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ginglis13!

@VachaShah VachaShah added the hacktoberfest Global event that encourages people to contribute to open-source. label Nov 1, 2023
@VachaShah VachaShah merged commit 6f3aeea into opensearch-project:main Nov 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Global event that encourages people to contribute to open-source.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants