Add cloudwatch logs for gradle-check job #434
Conversation
rishabh6788
requested review from
peterzhuamazon,
gaiksaya,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
Signed-off-by: Rishabh Singh <sngri@amazon.com>
| auto_removal: true, | ||
| log_stream_name: 'gradle-check.log/{date}', |
There was a problem hiding this comment.
Would date create too many log-streams? Also forgot what auto-removal does. Any idea?
There was a problem hiding this comment.
There is no limit on how many log streams can be created.
The choice is either push everything into one log stream or have one created daily so that it becomes easier to find the log one is looking for and faster, since it will contain only limited logs.
There was a problem hiding this comment.
Reg auto_removal, it is mainly helpful when you have some sort of log rotation happening, particularly on logs that are suffixed, e.g., sys.log is your main log file and your rotation logs creates sys.log.1 after each hour. In this case CW is supposed to clean up the rotated log.
But in our case it is not the case and the flag doesn't do anything.
There was a problem hiding this comment.
Yeah we can think about adding log retention policy. I believe it will be just too much logs. Even jenkins has 30 day retention policy for gradle-check logs. Can come as an enhancement.
Description
Add cloudwatch logs for gradle-check job.
In the future similar configuration can be added if we want to onboard other job logs as well.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.