Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update search and observability plugins #882

Closed
wants to merge 1 commit into from

Conversation

anirudha
Copy link
Contributor

@anirudha anirudha commented Nov 3, 2021

update search and observability plugins for 1.2
Signed-off-by: Anirudha Jadhav jadhanir@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

update search and observability plugins
@dblock
Copy link
Member

dblock commented Nov 4, 2021

The DCO check failed, needs a -s amend.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on other PRs. Also will need to rebase since manifest was updated.

NIT: Commit message could be a little bit more descriptive.

- name: queryWorkbenchDashboards
repository: https://github.com/opensearch-project/sql.git
working_directory: workbench
ref: "1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref refers to the git branch. It will fail if the "1.2" branch doesn't exist so most likely this will be main until the repo cuts a 1.2 branch. Also there is a PR to bump this up: opensearch-project/sql#254. This PR will need to be merged before we can add it to the manifest.

- name: reportsDashboards
repository: https://github.com/opensearch-project/dashboards-reports.git
working_directory: dashboards-reports
ref: "1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: "1.2"
- name: traceAnalyticsDashboards
repository: https://github.com/opensearch-project/trace-analytics.git
ref: "1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: ganttChartDashboards
repository: https://github.com/opensearch-project/dashboards-visualizations
working_directory: gantt-chart
ref: "1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was is all good! 1.2 branch exists and plugin is bumped! If anything it might be easiest to pull this one into another PR so that it's not blocked waiting on the other PRs.

@joshuali925
Copy link
Member

joshuali925 commented Nov 4, 2021

branch is in this repo I can't force push, i'll open another PR
#888 , you can close this

@dblock
Copy link
Member

dblock commented Nov 5, 2021

@anirudha Please make branches off your fork.

@dblock dblock closed this Nov 5, 2021
@dblock dblock deleted the update-search-and-observability-plugins branch November 5, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants